GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-109793: Allow Switching Interpreters During Finalization (gh-109794) by ericsnowcurrently · Pull Request #110705 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 11, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Essentially, we should check the thread ID rather than the thread state pointer.

(cherry-picked from commit 32466c9)

  • Issue: PyThreadState_Swap() During Finalization Causes Immediate Exit (AKA Daemon Threads Are Still the Worst!) #109793

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
pythongh-109793: Allow Switching Interpreters During Finalization (py…
3765c6f 
…thongh-109794)

Essentially, we should check the thread ID rather than the thread state pointer.
@bedevere-app bedevere-app Bot added the awaiting review label Oct 11, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 11, 2023
PyThreadState_Swap() During Finalization Causes Immediate Exit (AKA Daemon Threads Are Still the Worst!) #109793
Closed
@ericsnowcurrently ericsnowcurrently changed the title gh-109793: Allow Switching Interpreters During Finalization (gh-109794) [3.12] gh-109793: Allow Switching Interpreters During Finalization (gh-109794) Oct 11, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 11, 2023
gh-109793: Allow Switching Interpreters During Finalization #109794
Merged
@ericsnowcurrently
Update python3.12.abi
69c99df
@ericsnowcurrently ericsnowcurrently assigned Yhg1s Oct 11, 2023
ericsnowcurrently added 2 commits October 11, 2023 08:22
@ericsnowcurrently
Use _Py_atomic_pointer instead of adding _Py_atomic_ulong.
2bcb14c
@ericsnowcurrently
Update python3.12.abi
e472168
Yhg1s
Yhg1s reviewed Nov 20, 2023
View reviewed changes
Comment thread Include/internal/pycore_interp.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/internal/pycore_runtime.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added 4 commits November 20, 2023 11:21
@ericsnowcurrently
Move "_finalizing_id" down, for 3.12.0 layout compatibility.
b6db316
@ericsnowcurrently
Merge branch '3.12' into backport-32466c9-fix-finalization-other-tstates
986efbb
@ericsnowcurrently
Merge branch '3.12' into backport-32466c9-fix-finalization-other-tstates
586010b
@ericsnowcurrently
Update python3.12.abi
640461e
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) November 28, 2023 00:43
@ericsnowcurrently
ericsnowcurrently merged commit 82ae5a6 into python:3.12 Nov 28, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 28, 2023
@ericsnowcurrently
ericsnowcurrently deleted the backport-32466c9-fix-finalization-other-tstates branch November 28, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.