GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Lint Doc/ with Ruff by hugovk · Pull Request #111192 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Oct 22, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is with the default checks. Not too many changes needed!

What do you think, is that okay or should we specify some?

📚 Documentation preview 📚: https://cpython-previews--111192.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Lint Doc/ with Ruff
d06d3ef
@hugovk
hugovk requested a review from AlexWaygood as a code owner October 22, 2023 19:21
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 22, 2023
@hugovk hugovk added skip issue skip news labels Oct 22, 2023
@AlexWaygood
Merge branch 'main' into ruff-doc
d8719d1
AlexWaygood
AlexWaygood reviewed Oct 25, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, I'm in favour. As with #110917, though, I think maybe we should hold off here until we've posted on Discourse to check that others are okay with having more lints in CPython's CI. (I haven't got round to doing that post yet.) It's possible this and #110917 could be disruptive to people's workflows if they aren't familiar with ruff and/or pre-commit, so it would be good to give people a chance to voice their objections before going ahead with this. I'm in the pro-linter camp, but different people have different opinions on the usefulness of linters

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk and encukou reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@hugovk
hugovk marked this pull request as draft January 22, 2024 12:45
@bedevere-app bedevere-app Bot removed the awaiting core review label Jan 22, 2024
@hugovk hugovk mentioned this pull request Jul 19, 2024
GH-121970: Use Ruff to check and format the docs tools #122018
Merged
@hugovk

hugovk commented Jul 19, 2024

Copy link
Copy Markdown
Member Author

Superseded by #122018.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk closed this Jul 19, 2024
@hugovk
hugovk deleted the ruff-doc branch July 19, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland will be requested when the pull request is marked ready for review StanFromIreland is a code owner
@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee JacobCoffee will be requested when the pull request is marked ready for review JacobCoffee is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hugovk @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.