GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-79033: docs: Minor improvement to asyncio.Server.wait_closed() by Dreamsorcerer · Pull Request #111260 · python/cpython

Conversation

@Dreamsorcerer

@Dreamsorcerer Dreamsorcerer commented Oct 24, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@gvanrossum Just a small followup from #98582.

In aiohttp, for some reason it was originally written as calling wait_closed() before cancelling the open connections. So, from that wording in the Python documentation I always assumed that it was waiting for the sockets to stop listening, rather than waiting for the connections to be closed. Clearly this was wrong, and it actually did nothing, and aiohttp's shutdown should have been broken long ago.

In particular, the close() method says 'The sockets that represent existing incoming client connections are left open.'.
So, saying that it waits for close() to complete, which itself says connections are left open was a little confusing.


📚 Documentation preview 📚: https://cpython-previews--111260.org.readthedocs.build/

  • Issue: Counter-intuitive behavior of Server.close() / wait_closed() #79033

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Dreamsorcerer
docs: Minor improvement to asyncio.Server.wait_closed()
a9741dc
@Dreamsorcerer
Dreamsorcerer requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners October 24, 2023 12:56
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 24, 2023
@AlexWaygood AlexWaygood changed the title docs: Minor improvement to asyncio.Server.wait_closed() GH-79033: docs: Minor improvement to asyncio.Server.wait_closed() Oct 24, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 24, 2023
Counter-intuitive behavior of Server.close() / wait_closed() #79033
Closed
gvanrossum
gvanrossum approved these changes Oct 24, 2023
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phrasing is fine, and we should merge it.

Note, however, that there's another chapter to the wait_closed litany:
#79033 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 24, 2023
@Dreamsorcerer

Dreamsorcerer commented Oct 26, 2023

Copy link
Copy Markdown
Contributor Author

Superseded by #111336.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Dreamsorcerer Dreamsorcerer closed this Oct 26, 2023
@Dreamsorcerer
Dreamsorcerer deleted the patch-8 branch October 26, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Dreamsorcerer @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.