GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110481: Non-limited Py_INCREF/DECREF() in cpython/object.h by vstinner · Pull Request #111505 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 30, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Move the non-limited implementation of Py_INCREF() and Py_DECREF() from Include/object.h to Include/cpython/object.h.

Move static inline functions using Py_INCREF/DECREF() after the cpython/object.h include: Py_XINCREF(), Py_XDECREF(), Py_NewRef() and Py_XNewRef().

  • Issue: Implement biased reference counting in --disable-gil builds #110481

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Oct 30, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Oct 30, 2023
Implement biased reference counting in --disable-gil builds #110481
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 30, 2023
@vstinner vstinner mentioned this pull request Oct 30, 2023
gh-110481: Implement biased reference counting #110764
Merged
@vstinner
vstinner force-pushed the cpython_incref branch from 0e9c6c2 to 5b93bdd Compare October 30, 2023 16:47
@vstinner
pythongh-110481: Move non-limited Py_INCREF() to cpython/object.h
2d3a76e 
Move the non-limited implementation of Py_INCREF() and Py_DECREF()
from Include/object.h to Include/cpython/object.h.

Move static inline functions using Py_INCREF/DECREF() after the
cpython/object.h include: Py_XINCREF(), Py_XDECREF(), Py_NewRef() and
Py_XNewRef().
@vstinner
vstinner force-pushed the cpython_incref branch from 5b93bdd to 2d3a76e Compare October 30, 2023 16:50
@colesbury

colesbury commented Oct 30, 2023

Copy link
Copy Markdown
Contributor

Cool - I didn't think this was going to be possible.

I'm seeing some build failures locally in modules that target Py_LIMITED_API < 0x030c0000. These don't include either definition of Py_INCREF/DECREF because Include/cpython/object.h is only include if Py_LIMITED_API is NOT defined and the Include/object.h definition is only for Py_LIMITED_API >= 0x030c0000 (or debug builds).

In file included from ./Include/Python.h:52,
                 from ./Modules/_testimportmultiple.c:15:
./Include/object.h: In function ‘Py_XINCREF’:
./Include/object.h:968:9: error: implicit declaration of function ‘Py_INCREF’; did you mean ‘Py_XINCREF’? [-Werror=implicit-function-declaration]
  968 |         Py_INCREF(op);
      |         ^~~~~~~~~
      |         Py_XINCREF
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner marked this pull request as draft October 30, 2023 17:00
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 30, 2023
@vstinner

vstinner commented Oct 30, 2023

Copy link
Copy Markdown
Member Author

Cool - I didn't think this was going to be possible.

Sadly, it doesn't work because of Py_LIMITED_API+0 >= 0x030c0000 test in #if defined(Py_LIMITED_API) && (Py_LIMITED_API+0 >= 0x030c0000 || defined(Py_REF_DEBUG)). I should think about a different approach.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Oct 30, 2023
@vstinner
vstinner deleted the cpython_incref branch October 30, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.