GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111138: Test the public PyList C API by vstinner · Pull Request #111582 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 1, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add test_capi.test_list tests.

  • Issue: C API: Consider adding a public PyList_Extend() function #111138

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the needs backport to 3.12 only security fixes label Nov 1, 2023
@vstinner
vstinner requested a review from a team as a code owner November 1, 2023 00:11
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 1, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Nov 1, 2023
C API: Consider adding a public PyList_Extend() function #111138
Closed
@vstinner vstinner added the skip news label Nov 1, 2023
@vstinner

vstinner commented Nov 1, 2023

Copy link
Copy Markdown
Member Author

@serhiy-storchaka: Would you mind to review this change?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner force-pushed the testcapi_list branch from 89aef64 to d5fd400 Compare November 1, 2023 00:41
@serhiy-storchaka

serhiy-storchaka commented Nov 1, 2023

Copy link
Copy Markdown
Member

See also #111562.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka mentioned this pull request Nov 1, 2023
gh-111495: Add tests for PyList C API #111562
Merged
@vstinner
pythongh-111138: Test the public PyList C API
31036e7 
Add test_capi.test_list tests.
@vstinner
vstinner force-pushed the testcapi_list branch from d5fd400 to 31036e7 Compare November 8, 2023 15:10
@vstinner

vstinner commented Nov 8, 2023

Copy link
Copy Markdown
Member Author

I rebased my branch on main to fix a merge conflict.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 8, 2023

Copy link
Copy Markdown
Member Author

I merged #111562 instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Nov 8, 2023
@vstinner
vstinner deleted the testcapi_list branch November 8, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review needs backport to 3.12 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.