GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-111654: remove redundant decref in LOAD_FROM_DICT_OR_DEREF (GH-111655) by JelleZijlstra · Pull Request #111674 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Nov 3, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 3a1b09e)

  • Issue: redundant decref on the eval stack value in LOAD_FROM_DICT_OR_DEREF in error path #111654

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aisk @JelleZijlstra
[3.12] pythongh-111654: remove redundant decref in LOAD_FROM_DICT_OR_…
ca1da24 
…DEREF (pythonGH-111655)

(cherry picked from commit 3a1b09e)

Co-authored-by: AN Long <[email protected]>
@JelleZijlstra
JelleZijlstra requested a review from iritkatriel as a code owner November 3, 2023 04:12
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 3, 2023
This was referenced Nov 3, 2023
redundant decref on the eval stack value in LOAD_FROM_DICT_OR_DEREF in error path #111654
Closed
gh-111654: remove redundant decref on the eval stack value #111655
Merged
@JelleZijlstra
JelleZijlstra merged commit 1a95ad6 into python:3.12 Nov 3, 2023
@JelleZijlstra
JelleZijlstra deleted the backport-3a1b09e-3.12 branch November 3, 2023 14:02
@bedevere-app bedevere-app Bot removed the awaiting core review label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JelleZijlstra @aisk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.