GeezerVison is showing github.com — gh-112019: Add Py_complex_abs() function by vstinner · Pull Request #112107 · python/cpython
Conversation
vstinner
commented
Nov 15, 2023
•
edited by github-actions
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Add functions operating on Py_complex numbers:
- Py_complex_sum()
- Py_complex_diff()
- Py_complex_neg()
- Py_complex_prod()
- Py_complex_quot()
- Py_complex_pow()
- Py_complex_abs()
Add basic tests on these functions in test_capi.
📚 Documentation preview 📚: https://cpython-previews--112107.org.readthedocs.build/
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add functions operating on Py_complex numbers:
* Py_complex_sum()
* Py_complex_diff()
* Py_complex_neg()
* Py_complex_prod()
* Py_complex_quot()
* Py_complex_pow()
* Py_complex_abs()
Add basic tests on these functions in test_capi.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Only the numba is known to call _Py_c_pow(). Apparently, _Py_c functions are not used in the wild apart of the numba case. For now, I mark this PR as a draft.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I'm no longer convinced that we should make these APIs public. See #112019 discussion. I close this PR.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
AA-Turner
Awaiting requested review from AA-Turner
AA-Turner will be requested when the pull request is marked ready for review
AA-Turner is a code owner
ZeroIntensity
Awaiting requested review from ZeroIntensity
ZeroIntensity will be requested when the pull request is marked ready for review
ZeroIntensity is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.