GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111696: type(str) returns the fully qualified name by vstinner · Pull Request #112129 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 15, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

  • Update modules:

    • enum
    • functools
    • optparse
    • pdb
    • xmlrcp.server

  • Update tests:

    • test_dataclasses
    • test_descrtut
    • test_cmd_line_script
  • Issue: PEP 737: PyUnicode_FromFormat(): Add %T format to format the type name of an object #111696

📚 Documentation preview 📚: https://cpython-previews--112129.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-111696: type(str) returns the fully qualified name
f282b93 
* Update modules:

  * enum
  * functools
  * optparse
  * pdb
  * xmlrcp.server

* Update tests:

  * test_dataclasses
  * test_descrtut
  * test_cmd_line_script
@bedevere-app bedevere-app Bot mentioned this pull request Nov 15, 2023
PEP 737: PyUnicode_FromFormat(): Add %T format to format the type name of an object #111696
Closed
@vstinner
Update test_idle
365ca3d
@vstinner

vstinner commented Nov 15, 2023

Copy link
Copy Markdown
Member Author

I failed to fix test_basics() of test_enum which fails. But well, I don't think that this backward incompatible change is a good idea, so I don't plan to decidate too much time to it :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 16, 2023

Copy link
Copy Markdown
Member Author

I created this PR to show that changing str(type) is a bad idea: it breaks the backward compatibility and it requires to change too much code which currently works fine. I close this PR.
gpshead reacted with thumbs up emoji gpshead reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Nov 16, 2023
@vstinner
vstinner deleted the type_str branch November 28, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian will be requested when the pull request is marked ready for review gaogaotiantian is a code owner
@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy will be requested when the pull request is marked ready for review terryjreedy is a code owner
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger will be requested when the pull request is marked ready for review rhettinger is a code owner
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman will be requested when the pull request is marked ready for review ethanfurman is a code owner
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith will be requested when the pull request is marked ready for review ericvsmith is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.