GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-109538: Catch closed loop runtime error and issue warning (GH-111983) by dpr-0 · Pull Request #112142 · python/cpython

Conversation

@dpr-0

@dpr-0 dpr-0 commented Nov 16, 2023

Copy link
Copy Markdown
Contributor

Issue a ResourceWarning instead.

(cherry picked from commit e0f5127) gh-109538: Avoid RuntimeError when StreamWriter is deleted with closed loop (#111983)

Issue a ResourceWarning instead.

Co-authored-by: Hugo van Kemenade [email protected]
(cherry picked from commit e0f5127)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dpr-0 @hugovk
[3.12] pythongh-109538: Avoid RuntimeError when StreamWriter is delet…
5a71703 
…ed with closed loop (pythonGH-111983)

Issue a ResourceWarning instead.

(cherry picked from commit e0f5127)
pythongh-109538: Avoid RuntimeError when StreamWriter is deleted with closed loop (python#111983)

Issue a ResourceWarning instead.

Co-authored-by: Hugo van Kemenade <[email protected]>
(cherry picked from commit e0f5127)
@dpr-0
dpr-0 requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners November 16, 2023 07:22
@bedevere-app bedevere-app Bot added the awaiting review label Nov 16, 2023
This was referenced Nov 16, 2023
3.11.5 regression: StreamWriter.__del__ fails if event loop is already closed #109538
Closed
gh-109538: Catch closed loop runtime error and issue warning #111983
Merged
@bedevere-app bedevere-app Bot added the type-bug An unexpected behavior, bug, or error label Nov 16, 2023
@dpr-0 dpr-0 changed the title [3.12] gh-109538: Avoid RuntimeError when StreamWriter is deleted with closed loop (GH-111983) [3.12] gh-109538: Catch closed loop runtime error and issue warning (GH-111983) Nov 16, 2023
@dpr-0
Fix missing warnings import
15e8b1f
@gvanrossum
gvanrossum merged commit 2ef3676 into python:3.12 Nov 16, 2023
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 16, 2023
@dpr-0
dpr-0 deleted the backport-e0f5127-3.12 branch November 19, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dpr-0 @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.