GeezerVison is showing github.com — [3.12] gh-112358: Fix Python 3.12 regression with subclassing struct.Struct (GH-112424) by mdickinson · Pull Request #112426 · python/cpython
Conversation
mdickinson
commented
Nov 26, 2023
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Revert commit c8c0afc (PR GH-94532), which moved struct.Struct initialisation from Struct.__init__ to Struct.__new__. This caused issues with code in the wild that subclasses struct.Struct.. (cherry picked from commit 9fe6034)
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
…truct.Struct. (pythonGH-112424)
Revert commit c8c0afc (PR pythonGH-94532),
which moved `struct.Struct` initialisation from `Struct.__init__` to `Struct.__new__`.
This caused issues with code in the wild that subclasses `struct.Struct`..
(cherry picked from commit 9fe6034)
Co-authored-by: Mark Dickinson <[email protected]>
This was referenced Nov 26, 2023
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.