GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90102: Optimize io.FileIO.isatty() by serhiy-storchaka · Pull Request #112495 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 28, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Only invoke the isatty() system call for character devices and cache the result.

  • Issue: Avoid calling isatty() for most open() calls #90102

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-90102: Optimize io.FileIO.isatty()
b1ef1fa 
Only invoke the isatty() system call for character devices and
cache the result.
@bedevere-app bedevere-app Bot mentioned this pull request Nov 28, 2023
Avoid calling isatty() for most open() calls #90102
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Nov 28, 2023
@serhiy-storchaka serhiy-storchaka added topic-IO performance Performance or resource usage labels Nov 28, 2023
colesbury
colesbury reviewed Nov 28, 2023
View reviewed changes
Comment thread Modules/_io/fileio.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
Fix a race condition.
fae5fc5
@serhiy-storchaka

serhiy-storchaka commented Dec 14, 2023

Copy link
Copy Markdown
Member Author

It does not work, because the file descriptor can be reassigned from tty to non-tty and vice versa. The result of isatty() can not be cached.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this Dec 14, 2023
@serhiy-storchaka
serhiy-storchaka deleted the cache-fileio-isatty branch December 14, 2023 17:30
@cmaloney cmaloney mentioned this pull request Jul 11, 2024
GH-120754: Remove isatty call during regular open #121593
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review performance Performance or resource usage topic-IO

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.