GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107784 Document interpid C-API and new Unstable API for fetching `__main__` of interpreter by tonybaloney · Pull Request #112548 · python/cpython

Conversation

@tonybaloney

@tonybaloney tonybaloney commented Nov 30, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Add Documentation for C-API Used by the _xxsubinterpreters Module #107784

📚 Documentation preview 📚: https://cpython-previews--112548.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tonybaloney added 5 commits November 30, 2023 14:25
@tonybaloney
Document interpreter ID public API methods
3341106
@tonybaloney
Add documentation for interpreter ID objects
ebd3bcb
@tonybaloney
Move the docs to the init file
0bdabbf
@tonybaloney
Add PyUnstable_InterpreterState_GetMainModule
b9a8be3
@tonybaloney
Add blurb
8f9d7e1
@bedevere-app bedevere-app Bot mentioned this pull request Nov 30, 2023
Add Documentation for C-API Used by the _xxsubinterpreters Module #107784
Open
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 30, 2023
@tonybaloney

tonybaloney commented Nov 30, 2023

Copy link
Copy Markdown
Contributor Author

Can be back-ported to Python 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tonybaloney

tonybaloney commented Nov 30, 2023

Copy link
Copy Markdown
Contributor Author

@ericsnowcurrently interpid type is opaque, is that correct?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently added the topic-subinterpreters label Feb 27, 2024
blaisep
blaisep suggested changes May 20, 2024
View reviewed changes

@blaisep blaisep left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change

A interpreter ID identifies a interpreter and may be used as an int.

to

A interpreter ID identifies a interpreter and may be used as an :class:`int`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/c-api/init.rst
:c:func:`Py_FinalizeEx` will destroy all sub-interpreters that
haven't been explicitly destroyed at that point.

Interpreter ID Objects

@blaisep blaisep May 20, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm giving this some attention so that we can get it merged soon.
This section looks good so far

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/c-api/init.rst
Interpreter ID Objects
----------------------

A interpreter ID identifies a interpreter and may be used as an int.

@blaisep blaisep May 20, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk suggested that you link to the class definition,
changing

A interpreter ID identifies a interpreter and may be used as an int.

to

A interpreter ID identifies a interpreter and may be used as an :class:`int`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@blaisep blaisep May 20, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A interpreter ID identifies a interpreter and may be used as an int.
A interpreter ID identifies a interpreter and may be used as an :class:`int`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 20, 2024
blaisep
blaisep suggested changes May 20, 2024
View reviewed changes

@blaisep blaisep left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(added the change as a markdown suggestion to make it more convenient)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/c-api/init.rst
Interpreter ID Objects
----------------------

A interpreter ID identifies a interpreter and may be used as an int.

@blaisep blaisep May 20, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A interpreter ID identifies a interpreter and may be used as an int.
A interpreter ID identifies a interpreter and may be used as an :class:`int`.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently

ericsnowcurrently commented May 21, 2024

Copy link
Copy Markdown
Member

FYI, I've dropped interpreter ID objects.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blaisep

blaisep commented May 21, 2024

Copy link
Copy Markdown
Contributor

FYI, I've dropped interpreter ID objects.
Are you recommending that we close this PR? (Is is obsolete?)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented May 21, 2024

Copy link
Copy Markdown
Member

I'd need to double-check, but, yeah, we'd probably close this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blaisep

blaisep commented May 21, 2024

Copy link
Copy Markdown
Contributor

I'd need to double-check, but, yeah, we'd probably close this PR.

Thank you @ericsnowcurrently , I will ask @tonybaloney if he will close this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@willingc

willingc commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

@tonybaloney I'm going to close this PR. If needed we can reopen. Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@willingc willingc closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@blaisep blaisep blaisep requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir skip news topic-subinterpreters

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tonybaloney @ericsnowcurrently @blaisep @willingc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.