GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-111178: Docs: fix `traverseproc`, `inquiry`, and `destructor` parameters in slot typedefs table (GH-112742) by miss-islington · Pull Request #112792 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Dec 6, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In the slot typedefs table, the parameter of destructor
and the first parameter of traverseproc should both be
PyObject * rather than void *.
Same for inquiry.
(cherry picked from commit 00cce0f)

Co-authored-by: Christopher Chavez [email protected]

  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

📚 Documentation preview 📚: https://cpython-previews--112792.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@chrstphrchvz @miss-islington
pythongh-111178: Docs: fix traverseproc, inquiry, and `destructor…
371d231
…` parameters in slot typedefs table (pythonGH-112742)

In the slot typedefs table, the parameter of `destructor`
and the first parameter of `traverseproc` should both be
`PyObject *` rather than `void *`.
Same for `inquiry`.
(cherry picked from commit 00cce0f)

Co-authored-by: Christopher Chavez <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2023
gh-111178: Docs: fix traverseproc, inquiry, and destructor parameters in slot typedefs table #112742
Merged
@bedevere-app bedevere-app Bot added skip news docs Documentation in the Doc dir awaiting review labels Dec 6, 2023
@bedevere-app bedevere-app Bot mentioned this pull request Dec 6, 2023
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
encukou
encukou approved these changes Dec 6, 2023
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Dec 6, 2023
@encukou
encukou merged commit 399a3f2 into python:3.12 Dec 6, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 6, 2023
@miss-islington
miss-islington deleted the backport-00cce0f-3.12 branch January 2, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @encukou @chrstphrchvz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.