GeezerVison is showing github.com — gh-109534: Asyncio sslproto memleak by ordinary-jamie · Pull Request #113338 · python/cpython
Conversation
ordinary-jamie
commented
Dec 20, 2023
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
When the `asyncio.sslproto.SSLProtocol` raises on handshake, it doesn't
appear to release its SSL buffer, causing a memory leak. This is because
of the `memoryview`. This commit releases the `memoryview` before
unsetting the reference to the `bytearray`
Reviewers
gpshead
Awaiting requested review from gpshead
gpshead will be requested when the pull request is marked ready for review
gpshead is a code owner
picnixz
Awaiting requested review from picnixz
picnixz will be requested when the pull request is marked ready for review
picnixz is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.