GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-84852: Add basic font MIME types by MasterInQuestion · Pull Request #113592 · python/cpython

Conversation

@MasterInQuestion

@MasterInQuestion MasterInQuestion commented Dec 31, 2023 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

    Namely:
    |*| ".ttf": "font/ttf"
    |*| ".otf", ".otc", ".ttc": "font/otf"
    |*| ".woff": "font/woff"
    |*| ".woff2": "font/woff2"

    References:
    https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face#font_mime_types
    https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face/src#font_formats
    https://en.wikipedia.org/wiki/OpenType
    https://en.wikipedia.org/wiki/TrueType

  • Issue: Add missing mimetypes for fonts #84852

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MasterInQuestion
Add basic font MIME types
5e42988 
	Namely:
	|*| ".ttf": "font/ttf"
	|*| ".otf", ".otc", ".ttc": "font/otf"
	|*| ".woff": "font/woff"
	|*| ".woff2": "font/woff2"

	References:
	https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face#font_mime_types
	https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face/src#font_formats
	https://en.wikipedia.org/wiki/OpenType
	https://en.wikipedia.org/wiki/TrueType
@MasterInQuestion
MasterInQuestion requested a review from a team as a code owner December 31, 2023 00:33
@ghost

ghost commented Dec 31, 2023 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Dec 31, 2023

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Dec 31, 2023
serhiy-storchaka
serhiy-storchaka requested changes Jan 26, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that it is a good idea. But this change needs a NEWS file and tests. Please open an issue for reference.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Jan 26, 2024
@bedevere-app

bedevere-app Bot commented Jan 26, 2024

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MasterInQuestion

MasterInQuestion commented Mar 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

    How shall I write the NEWS file..?
    Linking directly to [ https://github.com/python/cpython/pull/113592/commits/5e42988fc5ae8dadf2d24ff4bb108a2876264b5d ]?

    The tests... It won't break anything, semantically verified.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MasterInQuestion
MasterInQuestion requested a review from serhiy-storchaka March 25, 2024 07:45
@serhiy-storchaka

serhiy-storchaka commented Mar 25, 2024

Copy link
Copy Markdown
Member

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

As for the tests, you should add cases related to your changes in Lib/test/test_mimetypes.py. No need to add cases for all changes, but I think that it would be interesting to add checks for guess_all_extensions('font/otf') and guess_extension('font/otf'). Make your changes consistent with other similar checks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Mar 25, 2024

Copy link
Copy Markdown
Member

There is already open issue for adding fonts to mimetypes: #84852.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka changed the title Add basic font MIME types gh-84852: Add basic font MIME types Mar 25, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 25, 2024
Add missing mimetypes for fonts #84852
Closed
@MasterInQuestion

MasterInQuestion commented Mar 25, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Author

    Finding issue for no issue...

    I did read.
    But the message... would:
    Add basic font MIME types: https://github.com/python/cpython/pull/113592/commits/5e42988fc5ae8dadf2d24ff4bb108a2876264b5d
    ; suffice?

    I believe the "test" files don't affect the eventual execution?
    If so... why bother?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Mar 25, 2024

Copy link
Copy Markdown
Member

The link is not needed, but add the list of added MIME types or file extensions.

Tests are needed to check that the change makes sense and that the following changes will not unintentionally cancel them. For example, there is an alternate patch for #84852, conflicting with this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MasterInQuestion

MasterInQuestion commented Mar 25, 2024

Copy link
Copy Markdown
Author

    Is not the whole change most clear simply tracing the link..?

    Rather than spending time on tests that might not work, or might be outright malapropos...
    Wouldn't it be more appropriate, to focus on the actual coding itself?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Mar 26, 2024

Copy link
Copy Markdown
Member

That's not how it works in software development. "Coding" without tests is meaningless.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this Mar 26, 2024
@MasterInQuestion

MasterInQuestion commented Mar 27, 2024

Copy link
Copy Markdown
Author

    So shall be testing without "Coding".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@MasterInQuestion @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.