GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-110383: Added explanation in Doc about array data types range. Based on GNU docs by LombardiDaniel · Pull Request #113708 · python/cpython

Conversation

@LombardiDaniel

@LombardiDaniel LombardiDaniel commented Jan 4, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

array -- data type sizes based on GNU documentation: https://www.gnu.org/software/libc/manual/html_node/Range-of-Type.html

  • Issue: Issues from [email protected] #110383

📚 Documentation preview 📚: https://cpython-previews--113708.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@LombardiDaniel
gh-110383: Added explanation about
fab94a1 
array -- data type sizes based on GNU documentation

Signed-off-by: Daniel Lombardi <[email protected]>
@ghost

ghost commented Jan 4, 2024 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Jan 4, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 4, 2024
Issues from [email protected] #110383
Closed
@LombardiDaniel

LombardiDaniel commented Jan 4, 2024

Copy link
Copy Markdown
Author

Can check altered docs at: library/array.html#module-array
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
LombardiDaniel added 3 commits January 15, 2024 09:26
@LombardiDaniel
Merge branch 'main' into main
27aa110
@LombardiDaniel
fix trailing whitespace lint
eb1b5b3 
Signed-off-by: Daniel Lombardi <[email protected]>
@LombardiDaniel
Merge branch 'main' into main
5b697cb
@serhiy-storchaka

serhiy-storchaka commented Jan 26, 2024

Copy link
Copy Markdown
Member

Isn't it outdated? I am not sure that on most machines that run Python long is 32-bit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronaldoussoren

ronaldoussoren commented Jan 26, 2024

Copy link
Copy Markdown
Contributor

Isn't it outdated? I am not sure that on most machines that run Python long is 32-bit.

Yes. See also my comment above. The proposed text is not correct in several ways:

  • The reference to GNU Libc is incorrect, size of the various types depends on the C ABI for particular platforms
  • On most platforms "long" is either 32-bit (32-bit CPUs and Windows) or 64-bit (64-bit CPUs except Windows)

Other than that I don't understand why adding these notes is helpful for users, these notes don't add anything that I (as a user) can use.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Jan 26, 2024

Copy link
Copy Markdown
Member

Eh. I do no see any other your comment.

I agree that this change is perhaps not very useful.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ronaldoussoren
ronaldoussoren reviewed Jan 27, 2024
View reviewed changes
Comment thread Doc/library/array.rst
Comment on lines +63 to +69
(2)
Int data types (signed or unsigned) can be 16 or 32 bits depending on the platform. The
same way that long data types can be 32 or 64 bits depending on the platform. On most
machines that run GNU C Library, an int is a 32-bit quantity. On most machines, long
int is also 32-bit, the same size as int. And lastly, on most machines, long long int
are 64-bit quantities. View more at: https://www.gnu.org/software/libc/manual/html_node/Range-of-Type.html

@ronaldoussoren ronaldoussoren Jan 14, 2024

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO "on most machines ..." doesn't really add anything.

In practice most general purpose machines are one of:

  • 32-bit CPUs: int, long are 32 bit, long long is 64 bit
  • 64-bit CPUs running Windows: int, long are 32-bit, long long is 64-bit
  • 64-bit CPUs running Unix-y systems (including Linux and macOS): int is 32-bit, long and long long are 64-bit

There are exceptions to this, but AFAIK most of those are special CPUs like DSPs or are from before the existence of C. Neither of which are useful to mention here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ronaldoussoren

ronaldoussoren commented Jan 27, 2024

Copy link
Copy Markdown
Contributor

Eh. I do no see any other your comment.

You should now, apparently it is important to actually post comments 🤦. That also explains why nobody reacted to my comment...

I agree that this change is perhaps not very useful.
erlend-aasland reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
terryjreedy
terryjreedy reviewed Feb 1, 2024
View reviewed changes
Comment thread Doc/library/array.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@LombardiDaniel @terryjreedy
Update Doc/library/array.rst
bf06b75 
Co-authored-by: Terry Jan Reedy <[email protected]>
@erlend-aasland erlend-aasland mentioned this pull request May 29, 2024
gh-110383: Clarify "non-integral" wording in pow() docs #119688
Merged
encukou
encukou reviewed May 30, 2024
View reviewed changes
Comment thread Doc/library/array.rst
Please migrate to ``'w'`` typecode.

(2)
As of 2024, 'h', 'i', 'l', and 'q' are usually 2, 4, 4 on Windows else 8, and 8 bytes.

@encukou encukou May 30, 2024

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note talks about h, so if it's kept, the \(2) should be added to the h & H lines in the table.

But, maybe this PR should be closed without merging. If you're wrinting cross-platform code you shouldn't rely on “common” values; if not you can use itemsize to find values that are actually right for your platform.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@terryjreedy

terryjreedy commented May 30, 2024

Copy link
Copy Markdown
Member

I have no more opinions on this. Do whatever.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@ronaldoussoren ronaldoussoren ronaldoussoren left review comments
@terryjreedy terryjreedy terryjreedy left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@LombardiDaniel @serhiy-storchaka @ronaldoussoren @terryjreedy @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.