GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103092: Port some `_ctypes` data types to heap types (alt) by neonene · Pull Request #113774 · python/cpython

Conversation

@neonene

@neonene neonene commented Jan 6, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

An alternative PR to #113630. This version will keep the behavior unchanged by making the MOD_ADD_TYPE() macro hack the metatype's tp_new slot.

  • Issue: Isolate Stdlib Extension Modules #103092

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@neonene
convert PyCData_Type family to heap types
59d4c27
@neonene
neonene requested a review from ericsnowcurrently as a code owner January 6, 2024 14:54
@bedevere-app bedevere-app Bot added the awaiting review label Jan 6, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 6, 2024
Isolate Stdlib Extension Modules #103092
Closed
24 of 25 tasks
@neonene neonene mentioned this pull request Jan 6, 2024
gh-103092: Port some _ctypes data types to heap types #113630
Closed
@erlend-aasland
erlend-aasland requested review from erlend-aasland and kumaraditya303 January 7, 2024 00:38
@encukou

encukou commented Jan 8, 2024

Copy link
Copy Markdown
Member

If we don't have API to solve this without the hack, I think it's better to keep _ctypes unported.
Let's keep discussion in #113630.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou closed this Jan 8, 2024
@neonene
neonene deleted the ctypes_alt branch January 9, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@neonene @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.