GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] GH-113661: unittest runner: Don't exit 5 if tests were skipped (GH-113856) by miss-islington · Pull Request #113875 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 9, 2024 •
edited by gpshead
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The intention of exiting 5 was to detect issues where the test suite
wasn't discovered at all. If we skipped tests, it was correctly
discovered.
(cherry picked from commit 3a9096c)

Co-authored-by: Stefano Rivera [email protected]

  • Issue: 3.12 starts to return an error when all tests in a test file are skipped #113661

📚 Documentation preview 📚: https://cpython-previews--113875.org.readthedocs.build/

Fixes #113661

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@stefanor @miss-islington
pythonGH-113661: unittest runner: Don't exit 5 if tests were skipped (p…
767e204 
…ythonGH-113856)

The intention of exiting 5 was to detect issues where the test suite
wasn't discovered at all. If we skipped tests, it was correctly
discovered.
(cherry picked from commit 3a9096c)

Co-authored-by: Stefano Rivera <[email protected]>
@bedevere-app bedevere-app Bot added awaiting review type-bug An unexpected behavior, bug, or error labels Jan 9, 2024
This was referenced Jan 9, 2024
GH-113661: unittest runner: Don't exit 5 if tests were skipped #113856
Merged
3.12 starts to return an error when all tests in a test file are skipped #113661
Closed
@gpshead gpshead self-assigned this Jan 9, 2024
@gpshead
gpshead merged commit 159e3db into python:3.12 Jan 9, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 9, 2024
@miss-islington
miss-islington deleted the backport-3a9096c-3.12 branch January 2, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @gpshead @stefanor
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.