GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-113205: test_multiprocessing.test_terminate: Test the API on threadpools (GH-114186) by miss-islington · Pull Request #114222 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 18, 2024

Copy link
Copy Markdown
Contributor

gh-113205: test_multiprocessing.test_terminate: Test the API works on threadpools

Threads can't be forced to terminate (without potentially corrupting too much
state), so the expected behaviour of ThreadPool.terminate is to wait for
the currently executing tasks to finish.

The entire test was skipped in GH-110848 (0e9c364).
Instead of skipping it entirely, we should ensure the API eventually succeeds:
use a shorter timeout.

For the record: on my machine, when the test is un-skipped, the task manages to
start in about 1.5% cases.
(cherry picked from commit c1db960)

Co-authored-by: Petr Viktorin [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou @miss-islington
pythongh-113205: test_multiprocessing.test_terminate: Test the API on…
09cd0dc
… threadpools (pythonGH-114186)

pythongh-113205: test_multiprocessing.test_terminate: Test the API works on threadpools

Threads can't be forced to terminate (without potentially corrupting too much
state), so the  expected behaviour of `ThreadPool.terminate` is to wait for
the currently executing tasks to finish.

The entire test was skipped in pythonGH-110848 (0e9c364).
Instead of skipping it entirely, we should ensure the API eventually succeeds:
use a shorter timeout.

For the record: on my machine, when the test is un-skipped, the task manages to
start in about 1.5% cases.
(cherry picked from commit c1db960)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Jan 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 18, 2024
gh-113205: test_multiprocessing.test_terminate: Test the API on threadpools #114186
Merged
@bedevere-app bedevere-app Bot added the skip news label Jan 18, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 18, 2024
Occasionally multiprocessing.test.*.test_threads can take 10 minutes #113205
Closed
@gpshead

gpshead commented Jan 18, 2024

Copy link
Copy Markdown
Member

holding off merging while a possible additional test fix is looked into on main. see the issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou
encukou merged commit c2a2126 into python:3.12 Jan 18, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Jan 18, 2024
@miss-islington
miss-islington deleted the backport-c1db960-3.12 branch January 2, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @gpshead @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.