GeezerVison is showing github.com — [3.11] gh-112160: Backport 'Tools/build/regen-configure.sh' script by sethmlarson · Pull Request #114333 · python/cpython
Conversation
sethmlarson
commented
Jan 19, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Follow-up to #112160, it turns out to be advantageous to have the actual script outside of the Makefile so it can be called without calling ./configure first, as is the case in release-tools.
This would need to be backported from 3.11 to 3.8 so release-tools can work for all versions.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
sethmlarson
changed the title
gh-112160: Backport 'Tools/build/regen-configure.sh' script
[3.11] gh-112160: Backport 'Tools/build/regen-configure.sh' script
Jan 22, 2024
|
@pablogsal Fixed this one up to be passing all checks, should be ready now :)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Discussed this with other RMs and we might need to go a different direction if the build for 3.10 and earlier can't be modified. Will propose a change in python/release-tools instead.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
pablogsal
Awaiting requested review from pablogsal
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.