GeezerVison

Hum, I don't get the PR description. So, what it does:

Create test_xml test package

* Create a new test_xml test package.
* Declare test_xml as a test package in libregrtest (findtests.py).
* Move the 7 tests to test_xml: test_minidom.py, test_pulldom.py,
  test_pyexpat.py, test_sax.py, test_xml_dom_minicompat.py,
  test_xml_etree_c.py and test_xml_etree.py.
* Move Lib/test/xmltestdata/ to Lib/test/test_xml/xmltestdata/.

It changes also findfile() of test.support: if subdir is not a string, use os.path.join(subdir). Is the findfile() needed? One option would to be avoid one level of directories: move the 5 test files from Lib/test/test_xml/xmltestdata/ to Lib/test/test_xml/ as done in other test packages. But keep c14n-20/ in a subdirectory.

What do you think about removing xmltestdata/ subdirectory @sobolevn?

I do not think that it is worth to do. Unlike to asyncio or email, xml is not a single package. It is a set of unrelated packages in a common parent namespace.

@serhiy-storchaka sorry, I don't agree. They might have any implementation details, but they are still sharing the same namespace and they use the same fixture files. It is logical for test to have the same namespaces as regular code does.

@vstinner I tried to remove xmltestdata/ directory, but I didn't go too well.
Since it relies on some exotic line-ending rules and possibly other magic stuff, I would say that keeping it as-is the same simplest and the safest thing we can do.

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Ok, sounds convincing 👍