GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — pythongh-109534: close transport if waiter is done by geraldog · Pull Request #114367 · python/cpython

Conversation

@geraldog

@geraldog geraldog commented Jan 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

I'm not able to reproduce #109534 anymore with this fix. Checking asyncio/sslproto.py it seems the waiter is only done on error or connection lost so this seems safe.

  • Issue: TLS/SSL asyncio leaks memory  #109534

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@geraldog
pythongh-109534: close transport if waiter is done
0467f20
@geraldog
geraldog requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners January 21, 2024 03:57
@ghost

ghost commented Jan 21, 2024

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

Click the button to sign:
CLA not signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Jan 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Jan 21, 2024
TLS/SSL asyncio leaks memory #109534
Closed
@bedevere-app

bedevere-app Bot commented Jan 21, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geraldog geraldog mentioned this pull request Jan 21, 2024
gh-109534: switch from sock_call to sock_call_ex in sock_send #114311
Closed
@gvanrossum

gvanrossum commented Jan 21, 2024

Copy link
Copy Markdown
Member

Checking asyncio/sslproto.py it seems the waiter is only done on error or connection lost so this seems safe.

Are you sure about that? ISTM that the waiter is passed to _SelectorSocketTransport which sets the waiter's result after connection_made() was called. And note how many tests are failing in CI!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geraldog

geraldog commented Jan 21, 2024

Copy link
Copy Markdown
Author

@gvanrossum actually being a RAW (Robert Anton WIlson) head I'm not sure of anything to be sure... but be kind with me and spare me some CI action - I just think I don't need to create the pull requests to annoy the maintainers to get the CI benefit while I chase this horrid bug.

But the code sure is failing to close the transport somewhere! I just don't know if it's python-code side or c-code side?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geraldog geraldog closed this Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@geraldog @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.