GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-114328: tty cbreak mode should not alter ICRNL (GH-114335) by miss-islington · Pull Request #114410 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jan 21, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
(cherry picked from commit fd49e22)

Co-authored-by: Gregory P. Smith [email protected]

  • Issue: read1 in cbreak mode returns 0x0D (instead of 0x0A) when <enter> is entered. #114328

📚 Documentation preview 📚: https://cpython-previews--114410.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead @miss-islington
pythongh-114328: tty cbreak mode should not alter ICRNL (pythonGH-114335
e8b93e0 
)

The terminal CR -> NL mapping setting should be inherited in cbreak mode as OSes do not specify altering it as part of their stty cbreak mode definition.
(cherry picked from commit fd49e22)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Jan 21, 2024
This was referenced Jan 21, 2024
read1 in cbreak mode returns 0x0D (instead of 0x0A) when <enter> is entered. #114328
Closed
gh-114328: tty cbreak mode should not alter ICRNL #114335
Merged
@bedevere-app bedevere-app Bot added the type-bug An unexpected behavior, bug, or error label Jan 21, 2024
gpshead
gpshead approved these changes Jan 21, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 21, 2024
@gpshead
gpshead enabled auto-merge (squash) January 21, 2024 23:27
@gpshead gpshead self-assigned this Jan 21, 2024
@gpshead
gpshead merged commit 33c1907 into python:3.12 Jan 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jan 21, 2024
@miss-islington
miss-islington deleted the backport-fd49e22-3.12 branch January 2, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.