GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113317: Remove Argument Clinic global variable 'clinic' by vstinner · Pull Request #114752 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 30, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Add Clinic.warn() and Clinic.fail() methods.
  • Add filename parameter to BlockParser constructor.
  • Add BlockParser.fail() method.
  • Add DSLParser.fail() method.
  • Pass lineno parameter to DSLParser.format_docstring(): more accurate error reporting.
  • Convert a few DSLParser static methods to regular method to be able to call self.fail().
  • Language.render() clinic parameter is now required: None is no longer accepted.
  • Remove warn() function.
  • Remove global variable 'clinic'.

fail() and warn() methods get filename and line number from the instance on which the method is called, rather than relying on a global variable 'clinic'.

  • Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner vstinner added the skip news label Jan 30, 2024
@vstinner
vstinner requested review from AlexWaygood and erlend-aasland as code owners January 30, 2024 14:43
@bedevere-app bedevere-app Bot mentioned this pull request Jan 30, 2024
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 30, 2024
@vstinner
pythongh-113317: Remove Argument Clinic global variable 'clinic'
b3d4da3
* Add Clinic.warn() and Clinic.fail() methods.
* Add filename parameter to BlockParser constructor.
* Add BlockParser.fail() method.
* Add DSLParser.fail() method.
* Pass lineno parameter to DSLParser.format_docstring(): more
  accurate error reporting.
* Convert a few DSLParser static methods to regular method to be able
  to call self.fail().
* Language.render() clinic parameter is now required: None is no
  longer accepted.
* Remove warn() function.
* Remove global variable 'clinic'.

fail() and warn() methods get filename and line number from the
instance on which the method is called, rather than relying on a
global variable 'clinic'.
@vstinner
vstinner force-pushed the ac_location branch from bb0ec1a to b3d4da3 Compare January 30, 2024 14:44
@vstinner

vstinner commented Jan 30, 2024

Copy link
Copy Markdown
Member Author

@erlend-aasland @AlexWaygood: Would you mind to review this change?

@erlend-aasland wrote a different approach: https://github.com/Argument-Clinic/cpython/pull/35

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Jan 30, 2024

Copy link
Copy Markdown
Member Author

See also https://github.com/Argument-Clinic/cpython/pull/36

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood

AlexWaygood commented Jan 31, 2024

Copy link
Copy Markdown
Member

I'm stepping down as an AC maintainer for now :) #114796

I trust you two to come to the right decision!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AlexWaygood
AlexWaygood removed their request for review January 31, 2024 11:40
@vstinner

vstinner commented Jan 31, 2024

Copy link
Copy Markdown
Member Author

I'm stepping down as an AC maintainer for now :) #114796

Even if you're not officially an "expert" or "code owner", your opinion still matters for me, and you're free to pick some reviews whenever you want. But I understand that I should ping you less often on such AC changes ;-)

AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Feb 6, 2024

Copy link
Copy Markdown
Member Author

Ping @erlend-aasland: Gentle reminder that I'm looking for a review :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Feb 15, 2024

Copy link
Copy Markdown
Contributor

Superseded by #115517.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland closed this Feb 15, 2024
@vstinner
vstinner deleted the ac_location branch January 14, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @AlexWaygood @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.