GeezerVison is showing github.com — gh-113317: Remove Argument Clinic global variable 'clinic' by vstinner · Pull Request #114752 · python/cpython
Conversation
vstinner
commented
Jan 30, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
- Add Clinic.warn() and Clinic.fail() methods.
- Add filename parameter to BlockParser constructor.
- Add BlockParser.fail() method.
- Add DSLParser.fail() method.
- Pass lineno parameter to DSLParser.format_docstring(): more accurate error reporting.
- Convert a few DSLParser static methods to regular method to be able to call self.fail().
- Language.render() clinic parameter is now required: None is no longer accepted.
- Remove warn() function.
- Remove global variable 'clinic'.
fail() and warn() methods get filename and line number from the instance on which the method is called, rather than relying on a global variable 'clinic'.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
* Add Clinic.warn() and Clinic.fail() methods.
* Add filename parameter to BlockParser constructor.
* Add BlockParser.fail() method.
* Add DSLParser.fail() method.
* Pass lineno parameter to DSLParser.format_docstring(): more
accurate error reporting.
* Convert a few DSLParser static methods to regular method to be able
to call self.fail().
* Language.render() clinic parameter is now required: None is no
longer accepted.
* Remove warn() function.
* Remove global variable 'clinic'.
fail() and warn() methods get filename and line number from the
instance on which the method is called, rather than relying on a
global variable 'clinic'.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I'm stepping down as an AC maintainer for now :) #114796
I trust you two to come to the right decision!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
I'm stepping down as an AC maintainer for now :) #114796
Even if you're not officially an "expert" or "code owner", your opinion still matters for me, and you're free to pick some reviews whenever you want. But I understand that I should ping you less often on such AC changes ;-)
|
AlexWaygood reacted with heart emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
erlend-aasland
Awaiting requested review from erlend-aasland
erlend-aasland is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.