GeezerVison is showing github.com — gh-112075: Add a little specialization thread safety by DinoV · Pull Request #114768 · python/cpython
Conversation
DinoV
commented
Jan 30, 2024
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
A couple of specializations call into dict apis w/o a lock and are doing multiple reads. This is just a small change to protect those reads with the dict lock.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
DinoV
changed the title
gh-112075: Lock dict when specializing module lookup
gh-112075: Add a little specialization thread safety
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me and should not have any effect on the default build.
However, I think we should generally hold off on incremental thread-safety changes to specialization until the dict thread-safe changes are done. I find it hard to tell how these sorts of changes will interact.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+847
to
+848
|
|
int res;
|
|
|
Py_BEGIN_CRITICAL_SECTION(dict);
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might be easier to read if it is refactored out into it's own function.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.