GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114570: Add PythonFinalizationError exception by vstinner · Pull Request #115352 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 12, 2024 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add PythonFinalizationError exception. This exception derived from RuntimeError is raised when an operation is blocked during the Python finalization.

The following functions now raise PythonFinalizationError, instead of RuntimeError:

  • _thread.start_new_thread()
  • subprocess.Popen
  • os.fork()
  • os.fork1()
  • os.forkpty()

Morever, _winapi.Overlapped finalizer now logs an unraisable PythonFinalizationError, instead of an unraisable RuntimeError.

  • Issue: Checking for sys.is_finalizing before thread.start() still yields "can't create new thread at interpreter shutdown" #114570

📚 Documentation preview 📚: https://cpython-previews--115352.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested review from ericsnowcurrently, gpshead and iritkatriel as code owners February 12, 2024 16:37
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 12, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 12, 2024
Checking for sys.is_finalizing before thread.start() still yields "can't create new thread at interpreter shutdown" #114570
Closed
@vstinner vstinner mentioned this pull request Feb 12, 2024
gh-109047: Add PythonFinalizationError exception #109809
Closed
@vstinner

vstinner commented Feb 12, 2024

Copy link
Copy Markdown
Member Author

cc @gpshead @ericsnowcurrently @serhiy-storchaka @sobolevn
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead
gpshead approved these changes Feb 13, 2024
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 13, 2024
serhiy-storchaka
serhiy-storchaka approved these changes Feb 13, 2024
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner and others added 2 commits February 14, 2024 22:52
@vstinner
pythongh-114570: Add PythonFinalizationError exception
2f33cd8 
Add PythonFinalizationError exception. This exception derived from
RuntimeError is raised when an operation is blocked during the Python
finalization.

The following functions now raise PythonFinalizationError, instead of
RuntimeError:

* _thread.start_new_thread()
* subprocess.Popen
* os.fork()
* os.fork1()
* os.forkpty()

Morever, _winapi.Overlapped finalizer now logs an unraisable
PythonFinalizationError, instead of an unraisable RuntimeError.
@gpshead @vstinner
minor grammar fixes to exceptions.rst
30bd9c9
@vstinner
vstinner force-pushed the python_finalization_error2 branch from 6d096b9 to 30bd9c9 Compare February 14, 2024 21:54
@vstinner

vstinner commented Feb 14, 2024

Copy link
Copy Markdown
Member Author

PR rebased on main to attempt to fix the macos-13 CI issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 3e7b7df into python:main Feb 14, 2024
@vstinner
vstinner deleted the python_finalization_error2 branch February 14, 2024 22:35
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 14, 2024
@vstinner

vstinner commented Feb 14, 2024

Copy link
Copy Markdown
Member Author

Merged. Thanks for the review @gpshead and @serhiy-storchaka.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @gpshead @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.