GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115383: Install `ncurses` in reusable macos workflow by sobolevn · Pull Request #115389 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 13, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Let's try this!

  • Issue: Undeclared function 'is_pad' on macos-13 GitHub runners #115383

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sobolevn
pythongh-115383: Install ncurses in reusable macos workflow
9cd43ff
@sobolevn
sobolevn requested review from ezio-melotti and hugovk as code owners February 13, 2024 07:05
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 13, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 13, 2024
Undeclared function 'is_pad' on macos-13 GitHub runners #115383
Closed
@sobolevn

sobolevn commented Feb 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

It, obviously, didn't help :(
Broken build: https://github.com/python/cpython/actions/runs/7882893355/job/21508865500?pr=115389

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn sobolevn closed this Feb 13, 2024
@ned-deily

ned-deily commented Feb 13, 2024

Copy link
Copy Markdown
Member

@sobolevn, See the Install Homebrew Dependencies section of the workflow log. Just installing ncurses from Homebrew isn't enough because Homebrew ncurses is keg-only:

For pkg-config to find ncurses you may need to set:
  export PKG_CONFIG_PATH="/usr/local/opt/ncurses/lib/pkgconfig"
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily

ned-deily commented Feb 13, 2024

Copy link
Copy Markdown
Member

And, of course, Homebrew uses different install paths for Intel Mac systems and Apple Silicon Mac systems so perhaps a better solution would be to adapt the GDBM_CFLAGS and GDBM_LIBS boilerplate from the devguide recipe.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn sobolevn reopened this Feb 13, 2024
@sobolevn

sobolevn commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

We can continue to experiment here :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv

ambv commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

perhaps a better solution would be to adapt the GDBM_CFLAGS and GDBM_LIBS boilerplate

You mean creating NCURSES_CFLAGS and NCURSES_LIBS?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

perhaps a better solution would be to adapt the GDBM_CFLAGS and GDBM_LIBS boilerplate

You mean creating NCURSES_CFLAGS and NCURSES_LIBS?

That would be CURSES_CFLAGS and CURSES_LIBS.

$ ./configure --help| grep -i curses
  CURSES_CFLAGS
              C compiler flags for CURSES, overriding pkg-config
  CURSES_LIBS linker flags for CURSES, overriding pkg-config
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ned-deily

ned-deily commented Feb 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

perhaps a better solution would be to adapt the GDBM_CFLAGS and GDBM_LIBS boilerplate

You mean creating NCURSES_CFLAGS and NCURSES_LIBS?

That would be CURSES_CFLAGS and CURSES_LIBS.

$ ./configure --help| grep -i curses
  CURSES_CFLAGS
              C compiler flags for CURSES, overriding pkg-config
  CURSES_LIBS linker flags for CURSES, overriding pkg-config

Yeah, I meant adapting the devguide's GDBM_CFLAGS and GDBM_LIBS recipe for CURSES_FLAGS and CURSES_LIBS but, as it appears the root causes were actually a caching issue and using a newer Apple SDK on an older system, that we shouldn't need to use the Homebrew ncurses going forward so this can probably safely be closed.

erlend-aasland and ambv reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@sobolevn sobolevn closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @ned-deily @ambv @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.