GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115119: Detect _decimal dependencies using pkg-config by erlend-aasland · Pull Request #115406 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 13, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Only libmpdec 4.0.0 supports pkg-config.

  • Issue: Unvendor libmpdec sources #115119

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
thesamesam reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@erlend-aasland
pythongh-115119: Detect _decimal dependencies using pkg-config
cff99f3 
Only libmpdec 4.0.0 supports pkg-config.
@bedevere-app bedevere-app Bot mentioned this pull request Feb 13, 2024
Unvendor libmpdec sources #115119
Closed
15 tasks done
erlend-aasland added 2 commits February 13, 2024 15:39
@erlend-aasland
Docs
e899ade
@erlend-aasland
Mark up configure env vars as options for consistency with the rest o…
1d26811 
…f the file
@erlend-aasland

erlend-aasland commented Feb 13, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Tested on macOS with the following scenarios:

$ ./configure && make                         # Uses CPython vendored mpdecimal
$ ./configure --with-system-libmpdec && make  # pkg-config detects Homebrew installed libmpdec 4.0.0
$ LIBMPDEC_CFLAGS="-I$HOME/install" \
  LIBMPDEC_LIBS="-L$HOME/install -lm -lmpdec" \
  ./configure --with-system-libmpdec && make  # Build with custom libmpdec 2.5.1

For some reason the latter fails, but I suspect it is an issue with my setup.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Feb 13, 2024

Copy link
Copy Markdown
Contributor Author

cc. @ned-deily
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland added 2 commits February 27, 2024 23:14
@erlend-aasland
Merge branch 'main' into ac/libmpdec
9302841
@erlend-aasland
Merge branch 'main' into ac/libmpdec
92ebae2
@erlend-aasland
erlend-aasland marked this pull request as ready for review March 30, 2024 18:48
@erlend-aasland
erlend-aasland requested review from corona10 and rhettinger as code owners March 30, 2024 18:48
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 30, 2024
@erlend-aasland
erlend-aasland requested a review from zware March 30, 2024 18:48
erlend-aasland
erlend-aasland commented Mar 30, 2024
View reviewed changes
Comment thread Modules/_decimal/_decimal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland commented Mar 30, 2024
View reviewed changes
Comment thread Modules/_decimal/_decimal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger
rhettinger removed their request for review March 30, 2024 19:21
erlend-aasland and others added 2 commits April 10, 2024 00:01
@erlend-aasland
ifdefs
4ccb592
@erlend-aasland
Merge branch 'main' into ac/libmpdec
c4057bd
ned-deily
ned-deily approved these changes Apr 29, 2024
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! FWIW, I was able to successfully build and test with mpdecimal 2.5.1 as well as 4.0.0.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 29, 2024
@ned-deily
Merge branch 'main' into ac/libmpdec
aa597e0
@erlend-aasland

erlend-aasland commented Apr 29, 2024

Copy link
Copy Markdown
Contributor Author

Thanks, Ned! I had forgotten about this :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
erlend-aasland merged commit c7e7bfc into python:main Apr 29, 2024
@erlend-aasland
erlend-aasland deleted the ac/libmpdec branch April 29, 2024 06:58
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 29, 2024
@Bo98 Bo98 mentioned this pull request Oct 14, 2024
Python 3.11 loses the ability to set PYTHON_DECIMAL_WITH_MACHINE #98557
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner
@zware zware Awaiting requested review from zware

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@erlend-aasland @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.