GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-112087: Fix reduce logic for the empty reverse iterator for list by corona10 · Pull Request #115471 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Feb 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Make list objects thread-safe in --disable-gil builds #112087

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-112087: Fix the logic for the empty reverse iterator for list
39255a9
@corona10
corona10 requested review from carljm and colesbury February 14, 2024 17:10
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 14, 2024
Make list objects thread-safe in --disable-gil builds #112087
Closed
4 tasks done
@corona10 corona10 changed the title [3.12] gh-112087: Fix the logic for the empty reverse iterator for list [3.12] gh-112087: Fix reduce logic for the empty reverse iterator for list Feb 14, 2024
@corona10

corona10 commented Feb 14, 2024

Copy link
Copy Markdown
Member Author 
/python.exe -m test test_iter -R 3:3
Using random seed: 1549591648
Raised RLIMIT_NOFILE: 256 -> 1024
0:00:00 load avg: 8.69 Run 1 test sequentially
0:00:00 load avg: 8.69 [1/1] test_iter
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm
carljm approved these changes Feb 14, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 14, 2024
@corona10
corona10 enabled auto-merge (squash) February 14, 2024 17:18
@corona10
corona10 merged commit 5ec52c3 into python:3.12 Feb 14, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 14, 2024
@corona10
corona10 deleted the gh-112087-3.12 branch February 15, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes
@colesbury colesbury Awaiting requested review from colesbury

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.