GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-24780: unittest assertEqual difference output foiled by newlines by nanjekyejoannah · Pull Request #11548 · python/cpython

Conversation

@nanjekyejoannah

@nanjekyejoannah nanjekyejoannah commented Jan 14, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I have created a fix for this issue and relevant tests.

https://bugs.python.org/issue24780

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 14, 2019
@bedevere-bot bedevere-bot added the awaiting review label Jan 14, 2019
tirkarthi
tirkarthi reviewed Jan 14, 2019
View reviewed changes
Comment thread Lib/unittest/case.py Outdated

@tirkarthi tirkarthi Jan 14, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. line is a list here and this causes test failures due to TypeError. lines seems to be a better name since it makes me think it's a single line but it's actually a list of lines.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/unittest/test/test_case.py Outdated

@tirkarthi tirkarthi Jan 14, 2019

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better test would be to test the output diff like https://github.com/python/cpython/blob/e709c1be97a04156c628f534116a236b9581aa2f/Lib/unittest/test/test_case.py#L1122 and it should be testing the failure cases and asserting the Exception output string.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nanjekyejoannah
nanjekyejoannah force-pushed the issue24780 branch from 222a928 to df4bdc9 Compare January 16, 2019 08:53
@nanjekyejoannah
unittest assertEqual difference output foiled by newlines
819b341
@nanjekyejoannah
nanjekyejoannah force-pushed the issue24780 branch from 6467b25 to 819b341 Compare January 16, 2019 09:06
blurb-it Bot and others added 2 commits January 16, 2019 09:11
@blurb-it
📜🤖 Added by blurb_it.
28bd893
@nanjekyejoannah
fix space
00190f8
@nanjekyejoannah

nanjekyejoannah commented Jan 22, 2019

Copy link
Copy Markdown
Contributor Author

@tirkarthi I made the necessary updates to this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tirkarthi

tirkarthi commented Jan 22, 2019

Copy link
Copy Markdown
Member

Thanks @nanjekyejoannah, tests should be fixed as noted in https://github.com/python/cpython/pull/11548/files#r247392463 . The tests are about the strings being equal and are not related to the issue. The actual tests should be about the diff output for the tests.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nanjekyejoannah nanjekyejoannah closed this Apr 14, 2019
@nanjekyejoannah

nanjekyejoannah commented Apr 14, 2019

Copy link
Copy Markdown
Contributor Author

closed this. Someone can open another PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjerdonek cjerdonek mentioned this pull request Apr 10, 2022
unittest assertEqual difference output foiled by newlines #68968
Closed
@mblahay

mblahay commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

@nanjekyejoannah Why did you close the PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tirkarthi tirkarthi tirkarthi left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nanjekyejoannah @tirkarthi @mblahay @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.