GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] Fix tests for XMLPullParser with Expat 2.6.0 (GH-115133) by sethmlarson · Pull Request #115535 · python/cpython

Conversation

@sethmlarson

@sethmlarson sethmlarson commented Feb 15, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Feeding the parser by too small chunks defers parsing to prevent CVE-2023-52425. Future versions of Expat may be more reactive. (cherry picked from commit 4a08e7b)

  • Issue: test.test_xml_etree*.XMLPullParserTest.test_simple_xml fails with (system) expat 2.6.0 #115133

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @sethmlarson
[3.9] pythongh-115133: Fix tests for XMLPullParser with Expat 2.6.0 (p…
cd1d5ea 
…ythonGH-115164)

Feeding the parser by too small chunks defers parsing to prevent
CVE-2023-52425. Future versions of Expat may be more reactive.
(cherry picked from commit 4a08e7b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Feb 15, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 15, 2024
test.test_xml_etree*.XMLPullParserTest.test_simple_xml fails with (system) expat 2.6.0 #115133
Closed
@bedevere-app bedevere-app Bot added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir labels Feb 15, 2024
@sethmlarson sethmlarson added the release-blocker label Feb 15, 2024
@sethmlarson sethmlarson mentioned this pull request Feb 15, 2024
gh-115133: Fix tests for XMLPullParser with Expat 2.6.0 #115164
Merged
@sethmlarson

sethmlarson commented Feb 15, 2024

Copy link
Copy Markdown
Contributor Author

Marked as release-blocker as it blocks #115474
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sethmlarson
sethmlarson requested a review from ambv February 15, 2024 20:26
@ambv
ambv merged commit dafb4f0 into python:3.9 Feb 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv Awaiting requested review from ambv

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

release-blocker tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Projects

Release and Deferred blockers 🚫
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sethmlarson @ambv @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.