GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — pythongh-109534: get rid of bytearray as class member by geraldog · Pull Request #115643 · python/cpython

Conversation

@geraldog

@geraldog geraldog commented Feb 19, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Confirmed by Issue author @rojamit that this workaround alleviates the memory leak.

This is just a simple workaround, it needs some more investigation on the C side of Python where the leak of bytearray as class member happens and why/how to fix it?

  • Issue: TLS/SSL asyncio leaks memory  #109534

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@geraldog
pythongh-109534: get rid of bytearray as class member
249121b
Workaround horrendous memory leaks, does not solve the
underlying issue of why bytearray as class member like
that will cause leaks, at least in this case
@geraldog
geraldog requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners February 19, 2024 03:20
@ghost

ghost commented Feb 19, 2024

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

Click the button to sign:
CLA not signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added the awaiting review label Feb 19, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 19, 2024
TLS/SSL asyncio leaks memory #109534
Closed
@bedevere-app

bedevere-app Bot commented Feb 19, 2024

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@geraldog

geraldog commented Feb 19, 2024

Copy link
Copy Markdown
Author

Tests will naturally fail as the function signature has changed, but before I put any more time into this I would like to hear from the maintainers about this kind of change.

Naturally, the origin of the bug should be eventually traced and then finally after this hypothetical fix, bytearray as class member can be reinstated. That's the precise meaning of the term workaround.

Meanwhile, real users are being affected by the issue, including at least me and @rojamit very badly. That's why we need this workaround for now until we can trace the real issue with memory allocating and never freeing outside the scope of the GC.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gvanrossum

gvanrossum commented Feb 19, 2024

Copy link
Copy Markdown
Member

This version isn't going to fly, the signature of buffer_updated() is documented and cannot be changed. Not even for an important work-around, sorry.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@geraldog

geraldog commented Feb 19, 2024

Copy link
Copy Markdown
Author

Understood @gvanrossum I appreciate the sincere feedback.

I do not have the time to track this further and it is beyond my expertise anyway, but let it be noted that bytearray as class member is causing at least the major part of the memory leak, and the description of the issue itself tells us 3.9 is unaffected - that's the timeframe for the introduction of bytearray as class member and I don't think it's mere coincidence.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@geraldog geraldog closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@geraldog @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.