GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] gh-97032: avoid test_squeezer crash on macOS buildbots (GH-115508) by miss-islington · Pull Request #115655 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 19, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

avoid test_squeezer crash on macOS buildbots
(cherry picked from commit 17a6533)

Co-authored-by: Ned Deily [email protected]

  • Issue: GUI tests: CPython 3.9 CI failure for macOS: macOS 11 (1107) or later required, have instead 11 (1106) ! #97032

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ned-deily @miss-islington
[3.10] pythongh-97032: avoid test_squeezer crash on macOS buildbots (p…
62b8d31
…ythonGH-115508)

avoid test_squeezer crash on macOS buildbots
(cherry picked from commit 17a6533)

Co-authored-by: Ned Deily <[email protected]>
@miss-islington
miss-islington requested a review from terryjreedy as a code owner February 19, 2024 13:43
@bedevere-app bedevere-app Bot added the awaiting review label Feb 19, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 19, 2024
[3.10] gh-97032: avoid test_squeezer crash on macOS buildbots #115508
Merged
@bedevere-app bedevere-app Bot added the skip news label Feb 19, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 19, 2024
GUI tests: CPython 3.9 CI failure for macOS: macOS 11 (1107) or later required, have instead 11 (1106) ! #97032
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Feb 19, 2024
@encukou

encukou commented Feb 20, 2024

Copy link
Copy Markdown
Member

!buildbot ARM64 MacOS

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Feb 20, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 62b8d31 🤖

The command will test the builders whose names match following regular expression: ARM64 MacOS

The builders matched are:

  • ARM64 MacOS M1 Refleaks NoGIL PR
  • ARM64 MacOS M1 NoGIL PR
  • ARM64 macOS PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented Feb 21, 2024

Copy link
Copy Markdown
Member

PR buildbot failures are unrelated.

@ambv, IMO this is the best way to fix the 3.9 buildbot failures. There's a more robust fix in later branches.
The other approaches considered are:

  • change library detection logic, which isn't ideal in source-only security releases
  • configuring the buildbot to use Homebrew tkinter -- too much work for a library that isn't really tested anyway

See Pablo's comment for 3.10:

While I understand the fix and the rationale, I have to say that I still find it a bit "hacky" (for the lack of a better term). Given that this is to fix CI in old branches I am fine merging it as it has no user impact, but ideally we should fix this in the build system in main if we detect that we are using an incompatible tkinter .

I any case, I am merging this as I think the proper fix will be more aggressive and we need to have the CI green to avoid hiding other problems. Thanks @encukou and @ned-deily for the PR and the explanation.

In main, the build system prefers pkg-config, and shouldn't pick up Apple's abandoned tk.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv changed the title [3.9] [3.10] gh-97032: avoid test_squeezer crash on macOS buildbots (GH-115508) [3.9] gh-97032: avoid test_squeezer crash on macOS buildbots (GH-115508) Feb 21, 2024
@ambv
ambv merged commit c23f749 into python:3.9 Feb 21, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 21, 2024
@miss-islington
miss-islington deleted the backport-17a6533-3.9 branch January 2, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @encukou @bedevere-bot @ambv @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.