GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115754: Export Py_None, Py_False, Py_True as symbols by vstinner · Pull Request #115755 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 21, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In the limited C API and the stable ABI, implement Py_None, Py_False and Py_True constants are symbols.

  • Issue: C API: Implement singletons as functions calls in the stable ABI 3.13 #115754

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested a review from encukou as a code owner February 21, 2024 09:57
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 21, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 21, 2024
C API: Implement singletons as functions calls in the stable ABI 3.13 #115754
Closed
@vstinner

vstinner commented Feb 21, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Two more constants to consider:

#define Py_Ellipsis (&_Py_EllipsisObject)
#define Py_NotImplemented (&_Py_NotImplementedStruct)

Update: I completed my PR to also cover these two constants.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner force-pushed the export_constants branch from 5dbd27b to 614df03 Compare February 21, 2024 10:45
@vstinner
vstinner requested a review from a team as a code owner February 21, 2024 10:45
@vstinner
pythongh-115754: Export Py_None, Py_False, Py_True as symbols
5002f4d 
In the limited C API and the stable ABI, implement Py_None, Py_False,
Py_True, Py_Ellipsis and Py_NotImplemented constants are symbols.
@vstinner
vstinner force-pushed the export_constants branch from 614df03 to 5002f4d Compare February 21, 2024 16:20
@vstinner
Fix make check-c-globals
8f0df5c
@vstinner
vstinner requested a review from ericsnowcurrently as a code owner February 21, 2024 16:31
@vstinner
vstinner marked this pull request as draft February 25, 2024 20:42
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 25, 2024
@vstinner vstinner mentioned this pull request Mar 5, 2024
gh-115754: Expose constants (ex: Py_None) as public ABI symbols (stable ABI) capi-workgroup/decisions#16
Closed
@vstinner

vstinner commented Mar 11, 2024

Copy link
Copy Markdown
Member Author

Counter-proposition: #116572 implement these constants as function calls in the limited C API.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 18, 2024

Copy link
Copy Markdown
Member Author

The C API Working Group chose to go with a function call instead: capi-workgroup/decisions#16
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Mar 18, 2024
@vstinner
vstinner deleted the export_constants branch March 18, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou encukou is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity will be requested when the pull request is marked ready for review ZeroIntensity is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.