GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "bpo-35537: subprocess can now use os.posix_spawnp (GH-11579)" by vstinner · Pull Request #11582 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jan 16, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 0785889.

https://bugs.python.org/issue35537

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
Revert "bpo-35537: subprocess can now use os.posix_spawnp (GH-11579)"
2a8bcac 
This reverts commit 0785889.
@vstinner
vstinner requested a review from gpshead as a code owner January 16, 2019 22:02
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 16, 2019
@bedevere-bot bedevere-bot added the awaiting merge label Jan 16, 2019
@vstinner

vstinner commented Jan 16, 2019

Copy link
Copy Markdown
Member Author

It seems like I was too excited and merged my PR #11579 too quickly. @izbyshev noticed that my change modified the subprocess behavior:
#11579

Honestly, I don't know if it's ok or not, but I case of doubt, I prefer to simpler revert to have more time to think about the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Jan 16, 2019
@vstinner vstinner mentioned this pull request Jan 16, 2019
bpo-35537: subprocess can now use os.posix_spawnp #11579
Merged
gpshead
gpshead approved these changes Jan 16, 2019
View reviewed changes
@vstinner
vstinner merged commit 8c34956 into python:master Jan 16, 2019
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 16, 2019
@vstinner
vstinner deleted the revert branch January 16, 2019 22:38
@izbyshev izbyshev mentioned this pull request Feb 18, 2019
bpo-35537: Change subprocess to use posix_spawnp instead of posix_spawn #11917
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @gpshead @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.