GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-115961: Improve tests for compressed file-like objects (GH-115963) by serhiy-storchaka · Pull Request #116039 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Feb 28, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Increase coverage for compressed file-like objects initialized with a file name, an open file object, a file object opened by file descriptor, and a file-like object without name and mode attributes (io.BytesIO)
  • Increase coverage for name, fileno(), mode, readable(), writable(), seekable() in different modes and states
  • No longer skip tests with bytes names
  • Test objects implementing the path protocol, not just pathlib.Path.
    (cherry picked from commit e72576c)
  • Issue: Add name and mode attributes to compressed file-like objects #115961

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
[3.11] pythongh-115961: Improve tests for compressed file-like objects (
7f57079 
pythonGH-115963)

* Increase coverage for compressed file-like objects initialized with a
  file name, an open file object, a file object opened by file
  descriptor, and a file-like object without name and mode attributes
  (io.BytesIO)
* Increase coverage for name, fileno(), mode, readable(), writable(),
  seekable() in different modes and states
* No longer skip tests with bytes names
* Test objects implementing the path protocol, not just pathlib.Path.
(cherry picked from commit e72576c)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
serhiy-storchaka requested a review from ethanfurman as a code owner February 28, 2024 09:24
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 28, 2024
gh-115961: Improve tests for compressed file-like objects #115963
Merged
@bedevere-app bedevere-app Bot added the skip news label Feb 28, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Feb 28, 2024
Add name and mode attributes to compressed file-like objects #115961
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Feb 28, 2024
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) February 28, 2024 09:24
@serhiy-storchaka
serhiy-storchaka merged commit becc615 into python:3.11 Feb 28, 2024
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 28, 2024
@serhiy-storchaka
serhiy-storchaka deleted the backport-e72576c-3.11 branch October 21, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.