GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] gh-116417: Move limited C API tests to _testlimitedcapi by vstinner · Pull Request #116567 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR to show how it can look alike to move most tests on the limited C API from _testcapi extension to the new _testlimitedcapi extension.

  • Issue: C API: Move limited C API tests from _testcapi to a new _testlimitedcapi extension #116417

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
vstinner added 6 commits March 10, 2024 09:47
@vstinner
pythongh-116417: Move limited C API tests to _testlimitedcapi
3b01457 
* Move bytes.c and sys.c from Modules/_testcapi/ to
  Modules/_testlimitedcapi/.
* Split some tests in two files, limited and non-limited:

  * abstract.c
  * dict.c
  * list.c
  * set.c

* Copy util.h to Modules/_testlimitedcapi/.
* Update test_capi.
@vstinner
unicode.c
5761f80
@vstinner
lower Py_LIMITED_API
2c984f6
@vstinner
long.c
0354b84
@vstinner
AC: don't use PyFloat_AS_DOUBLE() with limited C API
916dc57
@vstinner
float.c
422c188
@bedevere-app bedevere-app Bot mentioned this pull request Mar 10, 2024
C API: Move limited C API tests from _testcapi to a new _testlimitedcapi extension #116417
Closed
@vstinner

vstinner commented Mar 10, 2024

Copy link
Copy Markdown
Member Author

This PR creates 9 files in Modules/_testlimitedcapi/:

  • abstract.c
  • bytearray.c
  • bytes.c
  • dict.c
  • float.c
  • list.c
  • long.c
  • set.c
  • unicode.c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner added 4 commits March 10, 2024 18:40
@vstinner
Update test_bytes, test_class, test_codecs
12e8040
@vstinner
Fix Free Threading build
3bc12e7
@vstinner
Update PCbuild
bd8c80f
@vstinner
Fix typo
1521eaa
@vstinner vstinner added the skip news label Mar 10, 2024
@vstinner
Fix make check-c-globals
9684370
@vstinner vstinner mentioned this pull request Mar 11, 2024
gh-116417: Move limited C API list.c tests to _testlimitedcapi #116602
Merged
@vstinner vstinner closed this Mar 19, 2024
@vstinner
vstinner deleted the testlimitedcapi_move branch March 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.