GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-100746: Improve `test_named_expressions.py` (GH-116713) by miss-islington · Pull Request #116748 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 13, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 25684e7)

Co-authored-by: Nikita Sobolev [email protected]

  • Issue: Dict comprehensions are not tested at all in test_named_expressions.py #100746

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn @miss-islington
pythongh-100746: Improve test_named_expressions.py (pythonGH-116713)
4e72e66 
(cherry picked from commit 25684e7)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Mar 13, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 13, 2024
gh-100746: Improve test_named_expressions.py #116713
Merged
@bedevere-app bedevere-app Bot added the skip news label Mar 13, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 13, 2024
Dict comprehensions are not tested at all in test_named_expressions.py #100746
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Mar 13, 2024
@sobolevn sobolevn added the DO-NOT-MERGE label Mar 13, 2024
@sobolevn

sobolevn commented Mar 13, 2024

Copy link
Copy Markdown
Member

Hm, looks like that tests pass and this can be safely backported as-is, @emilyemorehouse, do you agree? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
sobolevn requested a review from emilyemorehouse March 14, 2024 08:53
@sobolevn sobolevn removed the DO-NOT-MERGE label Mar 14, 2024
@hugovk

hugovk commented Apr 6, 2024

Copy link
Copy Markdown
Member

3.11 is now security only, shall we close this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn sobolevn closed this Apr 6, 2024
@miss-islington
miss-islington deleted the backport-25684e7-3.11 branch January 2, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilyemorehouse emilyemorehouse Awaiting requested review from emilyemorehouse

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @sobolevn @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.