GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-114271: Clean Up _threadmodule.c by ericsnowcurrently · Pull Request #116776 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Mar 14, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This strictly moves code around into sections and adjust some names, in the interest of making it obvious where to find code and where to add new code. This is partly motivated by gh-114839. There will be follow-up PRs in the near future that take advantage of this cleanup.

At the moment, this is mostly a demonstration of some of the cleanup that I think would help make gh-114839 easier to review. I'd actually split this up into two or three parts. My gut also tells me that there's probably one extra PR that could be split out of gh-114839, though I haven't quite identified what it would be.

CC @mpage

  • Issue: Make _threadmodule.c thread-safe in --disable-gil builds #114271

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 14 commits March 13, 2024 11:00
@ericsnowcurrently
Make code sections more vistually distinct.
db6bfcf
@ericsnowcurrently
Combine thread execution code into its own section.
db48323
@ericsnowcurrently
Make module function names more distinct.
79c1d80
@ericsnowcurrently
Group the module functions into subsections.
75d97c1
@ericsnowcurrently
Factor out thread_bootstate_new().
3cace9e
@ericsnowcurrently
Pass the boot state to do_start_new_thread().
0e7a0f7
@ericsnowcurrently
Drop do_start_new_thread().
cec325e
@ericsnowcurrently
Move the thread execution code up near the top.
4c83cf5
@ericsnowcurrently
Clean up the _PyThreadHandle code.
23ca97b
@ericsnowcurrently
Factor out functions for tracking thread handles for fork.
41c7bd8
@ericsnowcurrently
Factor out threadhandleobject.c.
3db60f2
@ericsnowcurrently
Make _ThreadHandle a static builtin type.
d2fb9bd
@ericsnowcurrently
Factor out struct _PyThread_handle_data.
4d0edee
@ericsnowcurrently
Track the data, not the objects.
f1e8fa8
@ericsnowcurrently ericsnowcurrently added the skip news label Mar 14, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 14, 2024
Make _threadmodule.c thread-safe in --disable-gil builds #114271
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Mar 14, 2024
gh-114271: Fix race in Thread.join() #114839
Merged
@ericsnowcurrently ericsnowcurrently closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity will be requested when the pull request is marked ready for review ZeroIntensity is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.