GeezerVison is showing github.com — gh-113317: Move Argument Clinic converters to sub-modules by vstinner · Pull Request #116836 · python/cpython
Conversation
vstinner
commented
Mar 14, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Move the following classes to new sub-modules:
-
libclinic.return_converters:
- CReturnConverterAutoRegister
- CReturnConverter
-
libclinic.int_converters:
- bool_converter
- char_converter
- unsigned_char_converter
- byte_converter
- short_converter
- unsigned_short_converter
- int_converter
- unsigned_int_converter
- long_converter
- unsigned_long_converter
- long_long_converter
- unsigned_long_long_converter
- Py_ssize_t_converter
- slice_index_converter
- size_t_converter
-
libclinic.obj_converters:
- fildes_converter
- float_converter
- double_converter
- Py_complex_converter
- object_converter
- buffer
- rwbuffer
- robuffer
- str_converter
- PyBytesObject_converter
- PyByteArrayObject_converter
- unicode_converter
- Py_UNICODE_converter
- Py_buffer_converter
-
libclinic.misc_converters:
- defining_class_converter
- self_converter
Move also Null, NULL and TypeSet to libclinic.utils.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Move the following classes to new sub-modules:
* libclinic.return_converters:
* CReturnConverterAutoRegister
* CReturnConverter
* libclinic.int_converters:
* bool_converter
* char_converter
* unsigned_char_converter
* byte_converter
* short_converter
* unsigned_short_converter
* int_converter
* unsigned_int_converter
* long_converter
* unsigned_long_converter
* long_long_converter
* unsigned_long_long_converter
* Py_ssize_t_converter
* slice_index_converter
* size_t_converter
* libclinic.obj_converters:
* fildes_converter
* float_converter
* double_converter
* Py_complex_converter
* object_converter
* buffer
* rwbuffer
* robuffer
* str_converter
* PyBytesObject_converter
* PyByteArrayObject_converter
* unicode_converter
* Py_UNICODE_converter
* Py_buffer_converter
* libclinic.misc_converters:
* defining_class_converter
* self_converter
Move also Null, NULL and TypeSet to libclinic.utils.
Add create_python_parser_namespace() for PythonParser to pass names
to exec().
Fix --converters command in run_clinic(). Don't use dir(clinic) to
list converters, but use 'converters' and 'return_converters'
dictionaries instead.
Reviewers
erlend-aasland
Awaiting requested review from erlend-aasland
erlend-aasland is a code owner
AA-Turner
Awaiting requested review from AA-Turner
AA-Turner will be requested when the pull request is marked ready for review
AA-Turner is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.