GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-112536: Add support for thread sanitizer (TSAN) (gh-112648) by pitrou · Pull Request #116926 · python/cpython

Conversation

@pitrou

@pitrou pitrou commented Mar 17, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 88cb972)

Co-authored-by: Samet YASLAN [email protected]

  • Issue: Add support for thread sanitizer (TSAN) via --with-thread-sanitizer #112536

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
samety and others added 2 commits March 17, 2024 11:19
@samety @pitrou
[3.11] pythongh-112536: Add support for thread sanitizer (TSAN) (pyth…
1b765f7 
…ongh-112648)

(cherry picked from commit 88cb972)

Co-authored-by: Samet YASLAN <[email protected]>
@pitrou
Hide backported option from docs
304e341
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 17, 2024
This was referenced Mar 17, 2024
gh-112536: Add support for thread sanitizer (TSAN) #112648
Merged
Add support for thread sanitizer (TSAN) via --with-thread-sanitizer #112536
Closed
@pitrou
pitrou requested review from corona10 and erlend-aasland March 17, 2024 10:25
@pitrou

pitrou commented Mar 17, 2024

Copy link
Copy Markdown
Member Author

I checked that this builds successfully locally, and that a couple of tests pass (test_thread, test_io, test_importlib, test_threadsignals, test_syslog, test_threading_local).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pitrou
Apply configure diff to appease CI
276784f
corona10
corona10 approved these changes Mar 17, 2024
View reviewed changes

@corona10 corona10 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let's just wait if there are major objections or not :)
And by the way, thanks for the all suggestions (to care about the GIL build and backporting!)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 17, 2024
@pitrou
pitrou requested a review from pablogsal March 17, 2024 16:01
@pitrou

pitrou commented Mar 17, 2024

Copy link
Copy Markdown
Member Author

Okay, I'm not sure if it makes sense to backport this to 3.11, since the final bugfix release is scheduled for 2024-04-01, i.e. very soon. Perhaps we should just not bother.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pitrou

pitrou commented Mar 19, 2024

Copy link
Copy Markdown
Member Author

I'm closing for now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pitrou pitrou closed this Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland
@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pitrou @corona10 @samety
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.