GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-112536: Add --tsan test for reasonable TSAN execution times. (gh-116601) by pitrou · Pull Request #116929 · python/cpython

Conversation

@pitrou

@pitrou pitrou commented Mar 17, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit ebf29b3)

Also backport gh-116896, gh-116898, gh-116911: these are all adding to the list of TSan tests.

Co-authored-by: Donghee Na [email protected]

  • Issue: Add support for thread sanitizer (TSAN) via --with-thread-sanitizer #112536

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
corona10 and others added 5 commits March 17, 2024 16:38
@corona10 @pitrou
[3.12] pythongh-112536: Add --tsan test for reasonable TSAN execution…
3db7958 
… times. (pythongh-116601)

(cherry picked from commit ebf29b3)

Co-authored-by: Donghee Na <[email protected]>
@pitrou
Remove references to mimalloc
6f21c40
@corona10 @pitrou
pythongh-112536: Add more TSAN tests (python#116896)
731eef9 
---------

Co-authored-by: Antoine Pitrou <[email protected]>
@pitrou
pythongh-112536: Add test_threading to TSAN tests (python#116898)
a81f98b
@pitrou
pythonGH-112536: Add more TSan tests (python#116911)
22ff43c 
These may all exercise some non-trivial aspects of thread synchronization.
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 17, 2024
This was referenced Mar 17, 2024
gh-112536: Add --tsan test for reasonable TSAN execution times. #116601
Merged
Add support for thread sanitizer (TSAN) via --with-thread-sanitizer #112536
Closed
@pitrou
pitrou requested a review from corona10 March 17, 2024 15:57
@pitrou

pitrou commented Mar 17, 2024

Copy link
Copy Markdown
Member Author

I checked that these pass on a similar setup to the forthcoming CI configuration (Ubuntu 22.04, clang 14.0.6).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pitrou
pitrou requested a review from hugovk March 17, 2024 15:58
corona10
corona10 approved these changes Mar 18, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 18, 2024
@pitrou
pitrou merged commit fcb2301 into python:3.12 Mar 18, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 18, 2024
@pitrou
pitrou deleted the backport-ebf29b3-3.12 branch March 18, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@hugovk hugovk Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@pitrou @corona10
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.