GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] bpo-35537: Fix function name in os.posix_spawnp() errors by vstinner · Pull Request #11719 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Feb 1, 2019 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue35537

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the DO-NOT-MERGE label Feb 1, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 1, 2019
@bedevere-bot bedevere-bot added the awaiting merge label Feb 1, 2019
@vstinner vstinner added the skip news label Feb 1, 2019
@vstinner

vstinner commented Feb 1, 2019

Copy link
Copy Markdown
Member Author

I marked the PR as WIP because I noticed that test_posix fails even without my PR: see PR #11718.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Feb 1, 2019
bpo-35537: Add setsid parameter to os.posix_spawn() and os.posix_spawnp(). #11608
Merged
@vstinner
bpo-35537: Fix function name in os.posix_spawnp() errors
96d31ed
@vstinner

vstinner commented Feb 1, 2019

Copy link
Copy Markdown
Member Author

I merged PR #11718. I rebased this PR on top of it.

@izbyshev, @nanjekyejoannah: Would you mind to check that the function name is properly passed to all os.posix_spawn() and os.posix_spawnp() error messages in my PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Feb 1, 2019

Copy link
Copy Markdown
Member

@vstinner I opened https://bugs.python.org/issue35876 after seeing the buildbot failures to track the failing test fixes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
izbyshev
izbyshev approved these changes Feb 1, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting merge labels Feb 1, 2019
@nanjekyejoannah

nanjekyejoannah commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

@vstinner the function name passing lgtm. I haven't identified anything contrary.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 325e4ba into python:master Feb 1, 2019
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 1, 2019
@vstinner
vstinner deleted the spawnp_func_name branch February 1, 2019 14:47
@pablogsal pablogsal removed the DO-NOT-MERGE label Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@izbyshev izbyshev izbyshev approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@vstinner @pablogsal @nanjekyejoannah @izbyshev @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.