GeezerVison is showing github.com — [3.11] gh-117187: Fix XML tests for vanilla Expat <2.6.0 (GH-117203) by miss-islington · Pull Request #117245 · python/cpython
Conversation
miss-islington
commented
Mar 26, 2024
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
This fixes XML unittest fallout from the #115398 security fix. When configured using --with-system-expat on systems with older pre 2.6.0 versions of libexpat, our unittests were failing.
- sax|etree: Simplify Expat version guard where simplifiable
Idea by Matěj Cepl
- sax|etree: Fix reparse deferral tests for vanilla Expat <2.6.0
This does not fix the case of distros with an older version of libexpat with the 2.6.0 feature backported as a security fix. (Ubuntu is a known example of this with its libexpat1 2.5.0-2ubunutu0.1 package)
(cherry picked from commit 9f74e86)
Co-authored-by: Sebastian Pipping [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
)
This fixes XML unittest fallout from the python#115398 security fix. When configured using `--with-system-expat` on systems with older pre 2.6.0 versions of libexpat, our unittests were failing.
* sax|etree: Simplify Expat version guard where simplifiable
Idea by Matěj Cepl
* sax|etree: Fix reparse deferral tests for vanilla Expat <2.6.0
This *does not fix* the case of distros with an older version of libexpat with the 2.6.0 feature backported as a security fix. (Ubuntu is a known example of this with its libexpat1 2.5.0-2ubunutu0.1 package)
(cherry picked from commit 9f74e86)
Co-authored-by: Sebastian Pipping <[email protected]>
This was referenced Mar 26, 2024
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
tests
Tests in the Lib/test dir
type-bug
An unexpected behavior, bug, or error
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.