GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-116380: Add tests for `glob.glob0()` and `glob.glob1()`. by barneygale · Pull Request #117305 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Mar 27, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

These undocumented functions expand a single literal or (non-recursive) wildcard segment.

  • Issue: Speed up glob.glob() by reducing number of system calls made #116380

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
pythonGH-116380: Add tests for glob.glob0() and glob.glob1().
3ceffa8 
These undocumented functions expand a single literal or (non-recursive)
wildcard segment.
@barneygale barneygale added tests Tests in the Lib/test dir skip news labels Mar 27, 2024
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 27, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Mar 27, 2024
Speed up glob.glob() by reducing number of system calls made #116380
Open
@serhiy-storchaka

serhiy-storchaka commented Mar 28, 2024

Copy link
Copy Markdown
Member

They are undocumented and no longer used in the stdlib. glob.escape() and the root_dir parameter make them obsolete.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale

barneygale commented Mar 28, 2024

Copy link
Copy Markdown
Contributor Author

Indeed. But they're used by third-party code, and neither deprecated nor underscore-prefixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Mar 28, 2024

Copy link
Copy Markdown
Member

They are not underscored because this is not needed.

Opened #117337.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale

barneygale commented Mar 28, 2024

Copy link
Copy Markdown
Contributor Author

Does deprecating these functions preclude the addition of tests in your view?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Mar 28, 2024

Copy link
Copy Markdown
Member

The new tests LGTM. Some tests will be needed for deprecation anyway. But all tests added in this PR will be changed, and maybe moved to other place. This will only increase the size of the logs.

Would you mind creating a PR to deprecate these functions, along with adding new tests? Or do you prefer merging this PR first?
barneygale reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale

barneygale commented Mar 29, 2024

Copy link
Copy Markdown
Contributor Author

Good shout. I've opened #117371 to deprecate the functions, and incorporated the tests there. I'll close this PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@barneygale @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.