GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [WIP] gh-85283: Build _csv extension with limited C API by vstinner · Pull Request #117321 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 28, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Replace PyObject_VectorcallDict() with PyObject_Call() in _call_dialect(). Create a temporary tuple to pass the positional dialect argument.
  • Use PyUnicode_DecodeUTF32() to create an Unicode string from Py_UCS4 characters.
  • Replace PyErr_Format("%.200s", Py_TYPE(src)->tp_name) with PyErr_Format("%T", src).
  • Replace PyUnicode_READ_CHAR() with PyUnicode_ReadChar().
  • Replace PyUnicode_READ() with PyUnicode_ReadChar(). join_append_lineterminator() now takes an object (Unicode string) as argument.
  • Replace PyUnicode_GET_LENGTH() with PyUnicode_GetLength().
  • Replace Py_XSETREF() with assignement and Py_XDECREF().
  • Replace PyDict_Pop() with PyDict_DelItem().
  • Use PyType_GetSlot() to get tp_clear and tp_alloc slots.
  • Add some casts to (PyObject*).
  • Add an explicit #include <string.h>.
  • Issue: [C API] Convert a few stdlib extensions to the limited C API (PEP 384) #85283

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-85283: Build _csv extension with limited C API
ee94f36 
* Replace PyObject_VectorcallDict() with PyObject_Call() in
  _call_dialect(). Create a temporary tuple to pass the positional
  dialect argument.
* Use PyUnicode_DecodeUTF32() to create an Unicode string from
  Py_UCS4 characters.
* Replace PyErr_Format("%.200s", Py_TYPE(src)->tp_name) with
  PyErr_Format("%T", src).
* Replace PyUnicode_READ_CHAR() with PyUnicode_ReadChar().
* Replace PyUnicode_READ() with PyUnicode_ReadChar().
  join_append_lineterminator() now takes an object (Unicode string)
  as argument.
* Replace PyUnicode_GET_LENGTH() with PyUnicode_GetLength().
* Replace Py_XSETREF() with assignement and Py_XDECREF().
* Replace PyDict_Pop() with PyDict_DelItem().
* Use PyType_GetSlot() to get tp_clear and tp_alloc slots.
* Add some casts to (PyObject*).
* Add an explicit #include <string.h>.
@bedevere-app bedevere-app Bot mentioned this pull request Mar 28, 2024
[C API] Convert a few stdlib extensions to the limited C API (PEP 384) #85283
Closed
@vstinner

vstinner commented Apr 3, 2024

Copy link
Copy Markdown
Member Author

I don't think that it's worth it. I prefer to close this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Apr 3, 2024
@vstinner
vstinner deleted the limited_csv branch April 3, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.