GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-113317: Rename libclinic to argclinic by vstinner · Pull Request #117533 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 4, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Rename Tools/clinic/libclinic/ to Tools/clinic/argclinic/
  • Rename Tools/clinic/clinic.py to Tools/clinic/run_argclinic.py.
  • Add Tools/clinic/argclinic/main.py.
  • Convert absolute imports to imports related to the packages. For example, replace "from libclinic.cli import main" with "from .cli import main".
  • Remove "import clinic": import individual names.
  • "make clinic" now runs "python -m clinic".
  • Issue: Argument Clinic: split out global stateless helpers and constants from clinic.py #113317

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-113317: Rename libclinic to argclinic
de095fb 
* Rename Tools/clinic/libclinic/ to Tools/clinic/argclinic/
* Rename Tools/clinic/clinic.py to Tools/clinic/run_argclinic.py.
* Add Tools/clinic/argclinic/__main__.py.
* Convert absolute imports to imports related to the packages. For
  example, replace "from libclinic.cli import main" with
  "from .cli import main".
* Remove "import clinic": import individual names.
* "make clinic" now runs "python -m clinic".
@bedevere-app bedevere-app Bot mentioned this pull request Apr 4, 2024
Argument Clinic: split out global stateless helpers and constants from clinic.py #113317
Closed
@vstinner

vstinner commented Apr 4, 2024

Copy link
Copy Markdown
Member Author

@erlend-aasland: Here is a proposition to replace python clinic.py script with python -m argclinic (add __main__.py).

I also renamed "clinic" to "argclinic" to have a more specific name (be more explicit about the reference to the Monty Python sketch).

The PR is a little bit bigger than expect since there were still a few files importing libclinic to get many functions, rather than importing sub-modules.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

What is the rationale for this change?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 15, 2024

Copy link
Copy Markdown
Member Author

What is the rationale for this change?

My long term goal is to distribute Argument Clinic on PyPI. But I know that you disagree with that. I prefer to close this PR for now.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Apr 15, 2024
@vstinner
vstinner deleted the rename_argclinic branch April 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.