GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-117692: Fix `AttributeError` in `DocTestFinder` on wrapped `builtin_or_method` (GH-117699) by miss-islington · Pull Request #117708 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 10, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 4bb7d12)

Co-authored-by: Nikita Sobolev [email protected]
Co-authored-by: Alex Waygood [email protected]

  • Issue: doctest fails to collect tests from a C function that has been wrapped #117692

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn @AlexWaygood @miss-islington
pythongh-117692: Fix AttributeError in DocTestFinder on wrapped `…
7aea2ee 
…builtin_or_method` (pythonGH-117699)

(cherry picked from commit 4bb7d12)

Co-authored-by: Nikita Sobolev <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
This was referenced Apr 10, 2024
doctest fails to collect tests from a C function that has been wrapped #117692
Closed
gh-117692: Fix AttributeError in DocTestFinder on wrapped builtin_or_method #117699
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Apr 10, 2024
@AlexWaygood
AlexWaygood enabled auto-merge (squash) April 10, 2024 09:54
@AlexWaygood AlexWaygood self-assigned this Apr 10, 2024
@AlexWaygood

AlexWaygood commented Apr 10, 2024

Copy link
Copy Markdown
Member

Hmm, looks like the @doctest_skip_if decorator doesn't exist on Python 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood disabled auto-merge April 10, 2024 10:31
@AlexWaygood

AlexWaygood commented Apr 10, 2024

Copy link
Copy Markdown
Member

Hmm, looks like the @doctest_skip_if decorator doesn't exist on Python 3.12

@sobolevn, reckon we should just backport the doctest_skip_if decorator to 3.12 as part of this PR? It seems pretty simple and low-risk
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Apr 10, 2024

Copy link
Copy Markdown
Member

See #116758 (comment)
I also thought that skipping this doctest would be easier, but the oirignal PR author had a valid point about doctest internals change in 3.13. We can go with if ...: in this branch.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn and others added 2 commits April 10, 2024 16:57
@sobolevn
Update test_doctest.py
2410d2a
@AlexWaygood
Update test_doctest.py
fd446ad
@AlexWaygood
AlexWaygood enabled auto-merge (squash) April 10, 2024 14:02
@AlexWaygood
AlexWaygood merged commit 653ed76 into python:3.12 Apr 10, 2024
@bedevere-app bedevere-app Bot removed the awaiting review label Apr 10, 2024
@miss-islington
miss-islington deleted the backport-4bb7d12-3.12 branch January 2, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @AlexWaygood @sobolevn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.