GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-117114: Update availability and source code link in os.path.rst by nineteendo · Pull Request #117756 · python/cpython

Conversation

@nineteendo

@nineteendo nineteendo commented Apr 11, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I added a link to Lib/genericpath.py in the documentation of os.path (and removed the redundant availability notes) in this pull request: #117115, but this wasn't backported.

Note: the other changes in this pull request are NOT being backported.

📚 Documentation preview 📚: https://cpython-previews--117756.org.readthedocs.build/

  • Issue: Add isdevdrive to posixpath #117114

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nineteendo
Link to genericpath
983b159
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news labels Apr 11, 2024
@nineteendo
nineteendo marked this pull request as ready for review April 11, 2024 15:03
@bedevere-app bedevere-app Bot added the awaiting review label Apr 11, 2024
@nineteendo

nineteendo commented Apr 11, 2024

Copy link
Copy Markdown
Contributor Author

@erlend-aasland, could you add the skip-issue label? Or must I first make an issue for this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

@erlend-aasland, could you add the skip-issue label? Or must I first make an issue for this?

AFAICS, this belongs to gh-117114.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title [3.12] Link to genericpath [3.12] gh-117114: Update availability and source code link in os.path.rst Apr 11, 2024
@bedevere-app bedevere-app Bot mentioned this pull request Apr 11, 2024
Add isdevdrive to posixpath #117114
Closed
@erlend-aasland

erlend-aasland commented Apr 11, 2024

Copy link
Copy Markdown
Contributor

Are you sure about those availability adjustments?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo

nineteendo commented Apr 11, 2024

Copy link
Copy Markdown
Contributor Author

Yeah, when a function is defined in both Lib/ntpath.py & Lib/posixpath.py, it's available on all platforms.

I also think I know why these availability notes are here: these functions weren't available in macpath, and the notes weren't removed together with it: d7538dd.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo

nineteendo commented Apr 13, 2024

Copy link
Copy Markdown
Contributor Author

@zooba, thoughts?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nineteendo

nineteendo commented Apr 14, 2024

Copy link
Copy Markdown
Contributor Author

@AlexWaygood, do you have an opinion on this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Apr 15, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 15, 2024
@zooba

zooba commented Apr 15, 2024

Copy link
Copy Markdown
Member

I also think I know why these availability notes are here: these functions weren't available in macpath, and the notes weren't removed together with it

That and probably a few were only available on one, and then when we added the other we added to the list rather than removing the list.

This looks good to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit 2dcb267 into python:3.12 Apr 15, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 15, 2024
@nineteendo
nineteendo deleted the link-to-genericpath branch April 15, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nineteendo @erlend-aasland @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.