GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112075: Lock when inserting into shared keys by colesbury · Pull Request #117824 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Apr 12, 2024 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a draft PR similar to #117528, but:

  1. Separates out the handling of split keys
  2. Doesn't yet handle the necessary locking in _Py_dict_lookup for things like the PyDict_GetItemRef locking fallback.
  • Issue: Make dict objects thread-safe in --disable-gil builds #112075

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-112075: Lock when inserting into shared keys
3d270d2
@bedevere-app bedevere-app Bot mentioned this pull request Apr 12, 2024
Make dict objects thread-safe in --disable-gil builds #112075
Closed
@colesbury colesbury added the skip news label Apr 12, 2024
@colesbury colesbury mentioned this pull request Apr 12, 2024
Disable GIL by default in free-threaded build #116749
Closed
@colesbury
Fix return type
2e5797e
@colesbury colesbury closed this Apr 26, 2024
@colesbury

colesbury commented Apr 26, 2024

Copy link
Copy Markdown
Contributor Author

Addressed in #117528
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury deleted the gh-112075-lock-split-keys branch July 16, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane methane will be requested when the pull request is marked ready for review methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon will be requested when the pull request is marked ready for review markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@colesbury
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.